Attachment 658331 Details for Bug 875652 – don't perform unnecessary string formatting on boot device

[patch] don't perform unnecessary string formatting on boot device

0001-Don-t-perform-unnecessary-str-formatting-on-boot-dev.patch (text/plain), 1.07 KB, created by Samantha N. Bueno on 2012-12-05 18:30:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Samantha N. Bueno

Created: 2012-12-05 18:30:19 UTC

Size: 1.07 KB

patch

obsolete

>From 54c3922c3dccf057d2446c7d4dbede4c2b8bb554 Mon Sep 17 00:00:00 2001
>From: "Samantha N. Bueno" <sbueno+anaconda@redhat.com>
>Date: Wed, 5 Dec 2012 08:14:48 -0500
>Subject: [PATCH] Don't perform unnecessary str formatting on boot dev name
> (#875652)
>
>Remove some old cruft that was splitting a string into chars,
>causing a space to be injected between each char upon calling join().
>
>Resolves: rhbz#875652
>---
> booty/checkbootloader.py | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/booty/checkbootloader.py b/booty/checkbootloader.py
>index d58df8e..a9bd970 100644
>--- a/booty/checkbootloader.py
>+++ b/booty/checkbootloader.py
>@@ -101,12 +101,8 @@ def getBootDevString(line):
>     return dev
> 
> def getBootDevList(line):
>-    devs = string.split(line, '=')[1]
>-    rets = []
>-    for dev in devs:
>-        dev = getBootDevString("=%s" % (dev,))
>-        rets.append(dev)
>-    return string.join(rets)
>+    dev = string.split(line, '=')[1]
>+    return getBootDevString("=%s" % (dev,))
> 
> def getBootloaderTypeAndBoot(instRoot, storage):
>     haveGrubConf = 1
>-- 
>1.8.0
>

Actions: View | Diff

Attachments on bug 875652: 643349 | 658331