Attachment 663012 Details for Bug 879189 – Another upstream patch to amend the documentation

[patch] Another upstream patch to amend the documentation

0002-tdb-Improve-the-documentation-of-tdb_reopen-and-tdb_.patch (text/plain), 1.72 KB, created by Jakub Hrozek on 2012-12-13 15:14:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jakub Hrozek

Created: 2012-12-13 15:14:35 UTC

Size: 1.72 KB

patch

obsolete

>From c9053796b389758e8bacff4cd37d633fd65171f9 Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Tue, 11 Dec 2012 17:11:58 +0100
>Subject: [PATCH] tdb: Improve the documentation of tdb_reopen() and
> tdb_close().
>
>Reviewed-by: Simo Sorce <idra@samba.org>
>
>Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
>Autobuild-Date(master): Wed Dec 12 14:58:50 CET 2012 on sn-devel-104
>---
> lib/tdb/include/tdb.h | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/lib/tdb/include/tdb.h b/lib/tdb/include/tdb.h
>index d19439e760222536af380e86d470f996940080c8..e371e33876f2101ea400b54d0dd42eeb291a7dec 100644
>--- a/lib/tdb/include/tdb.h
>+++ b/lib/tdb/include/tdb.h
>@@ -212,9 +212,12 @@ void tdb_set_max_dead(struct tdb_context *tdb, int max_dead);
>  * This can be used after a fork to ensure that we have an independent seek
>  * pointer from our parent and to re-establish locks.
>  *
>- * @param[in]  tdb      The database to reopen.
>+ * @param[in]  tdb      The database to reopen. It will be free'd on error!
>  *
>  * @return              0 on success, -1 on error.
>+ *
>+ * @note Don't call tdb_error() after this function cause the tdb context will
>+ *       be freed on error.
>  */
> int tdb_reopen(struct tdb_context *tdb);
> 
>@@ -361,9 +364,12 @@ int tdb_append(struct tdb_context *tdb, TDB_DATA key, TDB_DATA new_dbuf);
> /**
>  * @brief Close a database.
>  *
>- * @param[in]  tdb      The database to close.
>+ * @param[in]  tdb      The database to close. The context will be free'd.
>  *
>  * @return              0 for success, -1 on error.
>+ *
>+ * @note Don't call tdb_error() after this function cause the tdb context will
>+ *       be freed on error.
>  */
> int tdb_close(struct tdb_context *tdb);
> 
>-- 
>1.8.0.1
>

Actions: View | Diff

Attachments on bug 879189: 649630 | 663011 | 663012