Attachment 663995 Details for Bug 886261 – php-when-review.txt

php-when-review.txt

php-when-review.txt (text/plain), 8.21 KB, created by Remi Collet on 2012-12-15 13:22:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2012-12-15 13:22:03 UTC

Size: 8.21 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>[x] = Pass
>[!] = Fail
>[-] = Not applicable
>[?] = Not evaluated
>[ ] = Manual review needed
>
>
>Issues:
>=======
>
>[!]: Spec file is legible and written in American English.
>	tab are not great (especially when set to "9")
>	I would prefer spaces only
>	=> Packager choice
>[!]: SourceX is a working URL.
>	you could use https://github.com/tplaner/When/archive/v0.3.tar.gz
>	which is a working URL (except than name is really ambiguous
>	=> Packager choice
>[!]: Requires correct, justified where necessary.
>	php-when-tests should requires phpunit. not a blocker as this sub-package 
>	will probably be used by very few dev.
>	=> Please consider adding it after import
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[-]: %build honors applicable compiler flags or justifies otherwise.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package contains no bundled libraries.
>[x]: Changelog in prescribed format.
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Sources contain only permissible code or content.
>[x]: Each %files section contains %defattr if rpm < 4.4
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package requires other packages for directories it uses.
>[x]: Package uses nothing in %doc for runtime.
>[-]: Package is not known to require ExcludeArch.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Fully versioned dependency in subpackages, if present.
>[x]: Package complies to the Packaging Guidelines
>[x]: Spec file lacks Packager, Vendor, PreReq tags.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "Unknown or generated". 1 files have unknown license. Detailed output of
>     licensecheck in /home/extras/SPECS/review/886261-php-
>     when/licensecheck.txt
>[x]: License file installed when any subpackage combination is installed.
>[x]: Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: Package do not use a name that already exist
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: Package installs properly.
>[x]: Package is not relocatable.
>[!]: Requires correct, justified where necessary.
>[x]: CheckResultdir
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[!]: Spec file is legible and written in American English.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: Package contains systemd file(s) if in need.
>[x]: File names are valid UTF-8.
>[-]: Large documentation must go in a -doc subpackage.
>     Note: Documentation size is 10240 bytes in 1 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>PHP:
>[!]: Package requires php-common instead of php.
>
>===== SHOULD items =====
>
>Generic:
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[x]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Dist tag is present.
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[?]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[x]: The placement of pkgconfig(.pc) files are correct.
>[x]: SourceX tarball generation or download is documented.
>     Note: Package contains tarball without URL, check comments
>[!]: SourceX / PatchY prefixed with %{name}.
>     Note: Source0 (When-0.3.tar.gz)
>[!]: SourceX is a working URL.
>[x]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[x]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Spec use %global instead of %define.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[!]: Spec file according to URL is the same as in SRPM.
>     Note: Spec file as given by url is not the same as in SRPM (see attached
>     diff).
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>     Note:  phpci static analyze results in
>     /home/extras/SPECS/review/886261-php-when/phpci.log
>
>
>Rpmlint
>-------
>Checking: php-when-0.3-2.fc17.noarch.rpm
>          php-when-tests-0.3-2.fc17.noarch.rpm
>          php-when-0.3-2.fc17.src.rpm
>php-when.noarch: W: spelling-error %description -l en_US iCalendar -> i Calendar, calendar, legendarily
>php-when.noarch: W: spelling-error %description -l en_US rrule -> rule, ruler, r rule
>php-when-tests.noarch: W: no-documentation
>php-when.src: W: spelling-error %description -l en_US iCalendar -> i Calendar, calendar, legendarily
>php-when.src: W: spelling-error %description -l en_US rrule -> rule, ruler, r rule
>php-when.src: W: invalid-url Source0: When-0.3.tar.gz
>3 packages and 0 specfiles checked; 0 errors, 6 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-when php-when-tests
>php-when.noarch: W: spelling-error %description -l en_US iCalendar -> i Calendar, calendar, legendarily
>php-when.noarch: W: spelling-error %description -l en_US rrule -> rule, ruler, r rule
>php-when-tests.noarch: W: no-documentation
>2 packages and 0 specfiles checked; 0 errors, 3 warnings.
># echo 'rpmlint-done:'
>
>
>
>Diff spec file in url and in SRPM
>---------------------------------
>--- /home/extras/SPECS/review/886261-php-when/srpm/php-when.spec	2012-12-15 14:08:11.000000000 +0100
>+++ /home/extras/SPECS/review/886261-php-when/srpm-unpacked/php-when.spec	2012-12-15 14:08:11.000000000 +0100
>@@ -65,5 +65,5 @@
> * Sat Dec 15 2012 Gregor TÃ¤tzner <brummbq@fedoraproject.org> - 0.3-2
> - enabled phpunit tests
>-- moved tests to %%{_datadir}/tests/when
>+- moved tests to %%{_datadir}/tests
> 
> * Tue Dec 11 2012 Gregor TÃ¤tzner <brummbq@fedoraproject.org> - 0.3-1
>
>
>Requires
>--------
>php-when-0.3-2.fc17.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    php-date  
>    php-spl  
>
>php-when-tests-0.3-2.fc17.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    php-when = 0.3-2.fc17
>
>
>
>Provides
>--------
>php-when-0.3-2.fc17.noarch.rpm:
>    
>    php-when = 0.3-2.fc17
>
>php-when-tests-0.3-2.fc17.noarch.rpm:
>    
>    php-when-tests = 0.3-2.fc17
>
>
>
>MD5-sum check
>-------------
>d804f445a4bf182a63e514d4a195a60534ca10c04e6d1b6f8e80bc96aa7fc328  v0.3.tar.gz
>d804f445a4bf182a63e514d4a195a60534ca10c04e6d1b6f8e80bc96aa7fc328  srpm-unpacked/When-0.3.tar.gz
>
>
>Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
>Buildroot used: fedora-17-x86_64
>Command line :/usr/bin/fedora-review -b 886261

Actions: View

Attachments on bug 886261: 663920 | 663994 | 663995