Attachment 664207 Details for Bug 785479 – php-horde-Horde-Constraint-review.txt

php-horde-Horde-Constraint-review.txt

php-horde-Horde-Constraint-review.txt (text/plain), 12.33 KB, created by Shawn Iwinski on 2012-12-16 03:50:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shawn Iwinski

Created: 2012-12-16 03:50:10 UTC

Size: 12.33 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>[x] = Pass
>[!] = Fail
>[-] = Not applicable
>[?] = Not evaluated
>[ ] = Manual review needed
>
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[-]: %build honors applicable compiler flags or justifies otherwise.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package contains no bundled libraries.
>[x]: Changelog in prescribed format.
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Sources contain only permissible code or content.
>[x]: Each %files section contains %defattr if rpm < 4.4
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[!]: Package requires other packages for directories it uses.
>
>     Since Horde_Test not required yet, "%dir %{pear_phpdir}/Horde" must be
>     used in %files.
>
>[x]: Package uses nothing in %doc for runtime.
>[-]: Package is not known to require ExcludeArch.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package complies to the Packaging Guidelines
>[x]: Spec file lacks Packager, Vendor, PreReq tags.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "Unknown or generated". 1 files have unknown license. Detailed output of
>     licensecheck in /home/siwinski/projects/fedora/reviews/785479-php-horde-
>     Horde-Constraint/licensecheck.txt
>[x]: Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: Package do not use a name that already exist
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[!]: Package must own all directories that it creates.
>
>     Since Horde_Test not required yet, "%dir %{pear_phpdir}/Horde" must be
>     used in %files.
>
>[x]: Package does not own files or directories owned by other packages.
>[x]: Package installs properly.
>[x]: Package is not relocatable.
>[x]: Requires correct, justified where necessary.
>[x]: CheckResultdir
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: No rpmlint messages.
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file is legible and written in American English.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: Package contains systemd file(s) if in need.
>[x]: File names are valid UTF-8.
>[x]: Large documentation must go in a -doc subpackage.
>     Note: Documentation size is 10240 bytes in 1 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>PHP:
>[x]: Package requires php-common instead of php.
>
>===== SHOULD items =====
>
>Generic:
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[!]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Dist tag is present.
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[x]: The placement of pkgconfig(.pc) files are correct.
>[x]: Scriptlets must be sane, if used.
>[x]: SourceX tarball generation or download is documented.
>[x]: SourceX / PatchY prefixed with %{name}.
>     Note: Source0 (Horde_Constraint-2.0.1.tgz)
>     
>     Standard PHP PEAR naming convention.
>     
>[x]: SourceX is a working URL.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Spec use %global instead of %define.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: No rpmlint messages.
>[x]: Spec file according to URL is the same as in SRPM.
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>
>
>Rpmlint
>-------
>Checking: php-horde-Horde-Constraint-2.0.1-1.fc17.noarch.rpm
>          php-horde-Horde-Constraint-2.0.1-1.fc17.src.rpm
>2 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-horde-Horde-Constraint
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-horde-Horde-Constraint-2.0.1-1.fc17.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    /bin/sh  
>    /usr/bin/pear  
>    php-channel(pear.horde.org)  
>    php-common >= 5.3.0
>    php-pear(PEAR) >= 1.7.0
>
>
>
>Provides
>--------
>php-horde-Horde-Constraint-2.0.1-1.fc17.noarch.rpm:
>    
>    php-horde-Horde-Constraint = 2.0.1-1.fc17
>    php-pear(pear.horde.org/Horde_Constraint) = 2.0.1
>
>
>
>MD5-sum check
>-------------
>http://pear.horde.org/get/Horde_Constraint-2.0.1.tgz :
>  CHECKSUM(SHA256) this package     : bd959fbbeaac0519ec6de8dc7c5e33ab01858e20997be68b895b4305d2b87b19
>  CHECKSUM(SHA256) upstream package : bd959fbbeaac0519ec6de8dc7c5e33ab01858e20997be68b895b4305d2b87b19
>
>
>
>PHPCI
>-----
>
>lib
>---
>-------------------------------------------------------------------------------
>PHP COMPAT INFO EXTENSION SUMMARY
>-------------------------------------------------------------------------------
>  EXTENSION                             EXT min/Max       PHP min/Max     COUNT
>-------------------------------------------------------------------------------
>  Core                                  4.0.0             4.0.0               8
>  pcre                                  0.0               4.0.0               1
>  standard                              4.0.4             4.0.0               5
>-------------------------------------------------------------------------------
>-------------------------------------------------------------------------------
>PHP COMPAT INFO CLASS SUMMARY
>-------------------------------------------------------------------------------
>  CLASS                                 EXT min/Max       PHP min/Max     COUNT
>-------------------------------------------------------------------------------
>  Horde_Constraint                                        4.0.0               2
>  Horde_Constraint_AlwaysFalse                            5.0.0               1
>  Horde_Constraint_AlwaysTrue                             5.0.0               1
>  Horde_Constraint_And                                    5.0.0               1
>  Horde_Constraint_Coupler                                5.0.0               3
>  Horde_Constraint_IsEqual                                5.0.0               1
>  Horde_Constraint_IsInstanceOf                           5.0.0               1
>  Horde_Constraint_Not                                    5.0.0               1
>  Horde_Constraint_Null                                   5.0.0               1
>  Horde_Constraint_Or                                     5.0.0               1
>  Horde_Constraint_PregMatch                              5.0.0               1
>  IllegalArgumentException                                4.0.0               1
>-------------------------------------------------------------------------------
>-------------------------------------------------------------------------------
>PHP COMPAT INFO CONSTANT SUMMARY
>-------------------------------------------------------------------------------
>  CONSTANT                              EXT min/Max       PHP min/Max     COUNT
>-------------------------------------------------------------------------------
>  FALSE                                 Core-4.0.0        4.0.0               3
>  TRUE                                  Core-4.0.0        4.0.0               3
>-------------------------------------------------------------------------------
>
>tests
>-----
>-------------------------------------------------------------------------------
>PHP COMPAT INFO EXTENSION SUMMARY
>-------------------------------------------------------------------------------
>  EXTENSION                             EXT min/Max       PHP min/Max     COUNT
>-------------------------------------------------------------------------------
>  Core                                  4.0.0             4.0.0               7
>  standard                              4.0.0             4.0.0               1
>-------------------------------------------------------------------------------
>-------------------------------------------------------------------------------
>PHP COMPAT INFO CLASS SUMMARY
>-------------------------------------------------------------------------------
>  CLASS                                 EXT min/Max       PHP min/Max     COUNT
>-------------------------------------------------------------------------------
>  Horde_Constraint_AlwaysFalse                            4.0.0              16
>  Horde_Constraint_AlwaysFalseTest                        5.0.0               1
>  Horde_Constraint_AlwaysTrue                             4.0.0              18
>  Horde_Constraint_AlwaysTrueTest                         5.0.0               1
>  Horde_Constraint_And                                    4.0.0               6
>  Horde_Constraint_AndTest                                5.0.0               1
>  Horde_Constraint_IsInstanceOf                           4.0.0               2
>  Horde_Constraint_IsInstanceOfTest                       5.0.0               1
>  Horde_Constraint_Not                                    4.0.0               2
>  Horde_Constraint_NotTest                                5.0.0               1
>  Horde_Constraint_Null                                   4.0.0               2
>  Horde_Constraint_NullTest                               5.0.0               1
>  Horde_Constraint_Or                                     4.0.0               6
>  Horde_Constraint_OrTest                                 5.0.0               1
>  Horde_Constraint_PregMatch                              4.0.0               2
>  Horde_Constraint_PregMatchTest                          5.0.0               1
>  Horde_Test_AllTests                                     4.0.0               1
>  Horde_Test_Bootstrap                                    4.0.0               1
>  Horde_Test_Case                                         4.0.0               8
>  StdClass                                                4.0.0               2
>-------------------------------------------------------------------------------
>-------------------------------------------------------------------------------
>PHP COMPAT INFO CONSTANT SUMMARY
>-------------------------------------------------------------------------------
>  CONSTANT                              EXT min/Max       PHP min/Max     COUNT
>-------------------------------------------------------------------------------
>  FALSE                                 Core-4.0.0        4.0.0               2
>  NULL                                  Core-4.0.0        4.0.0               1
>  TRUE                                  Core-4.0.0        4.0.0               2
>  __FILE__                              Core-4.0.0        4.0.0               2
>-------------------------------------------------------------------------------
>
>
>
>Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
>Buildroot used: fedora-17-x86_64
>Command line :/usr/bin/fedora-review -b 785479

Actions: View

Attachments on bug 785479: 664207 | 665844 | 665845