Attachment 666248 Details for Bug 888815 – patch diff

[patch] patch diff

wfk21-product-branch-BZ-888815.patch (text/plain), 3.27 KB, created by ivassile on 2012-12-19 17:56:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ivassile

Created: 2012-12-19 17:56:05 UTC

Size: 3.27 KB

patch

obsolete

>From ca9b17faa43a3b5c0bca9c4b5f035f45c3d53be2 Mon Sep 17 00:00:00 2001
>From: Brian Leathem <bleathem@gmail.com>
>Date: Thu, 6 Dec 2012 01:11:50 -0800
>Subject: [PATCH] RF-12639: Disabled the resize listener during the intialize
> and updateLayout methods
>
>---
> .../resources/org.richfaces/extendedDataTable.js   |   15 ++++++++++++++-
> 1 files changed, 14 insertions(+), 1 deletions(-)
>
>diff --git a/iteration/ui/src/main/resources/META-INF/resources/org.richfaces/extendedDataTable.js b/iteration/ui/src/main/resources/META-INF/resources/org.richfaces/extendedDataTable.js
>index a9accce..1017227 100644
>--- a/iteration/ui/src/main/resources/META-INF/resources/org.richfaces/extendedDataTable.js
>+++ b/iteration/ui/src/main/resources/META-INF/resources/org.richfaces/extendedDataTable.js
>@@ -180,7 +180,8 @@
>                     richfaces.Event.bind(this.element, "rich:ready", this.options['onready']);
>                 }
>                 jQuery(document).ready(jQuery.proxy(this.initialize, this));
>-                jQuery(window).bind("resize", jQuery.proxy(this.updateLayout, this));
>+                this.resizeEventName = "resize.rf.edt." + this.id;
>+                this.activateResizeListener();
>                 jQuery(this.scrollElement).bind("scroll", jQuery.proxy(this.updateScrollPosition, this));
>                 this.bindHeaderHandlers();
>                 jQuery(this.element).bind("rich:onajaxcomplete", jQuery.proxy(this.ajaxComplete, this));
>@@ -270,6 +271,7 @@
>             },
> 
>             updateLayout: function() {
>+                this.deActivateResizeListener();
>                 this.headerCells.height("auto");
>                 var headerCellHeight = 0;
>                 this.headerCells.each(function() {
>@@ -323,6 +325,7 @@
>                 if (this.bodyElement.offsetHeight > height || !this.contentElement) {
>                     this.bodyElement.style.height = height + "px";
>                 }
>+                this.activateResizeListener();
>             },
> 
>             adjustResizers: function() { //For IE7 only.
>@@ -373,6 +376,7 @@
>             },
> 
>             initialize: function() {
>+                this.deActivateResizeListener();
>                 this.bodyElement = document.getElementById(this.id + ":b");
>                 this.bodyElement.tabIndex = -1; //TODO don't use tabIndex.
>                 this.normalPartStyle = richfaces.utils.getCSSRule("div.rf-edt-cnt").style;
>@@ -400,6 +404,7 @@
>                 this.parts = jQuery(this.element).find(".rf-edt-cnt, .rf-edt-ftr-cnt");
>                 this.updateLayout();
>                 this.updateScrollPosition(); //TODO Restore horizontal scroll position
>+                this.activateResizeListener();
>                 jQuery(this.element).triggerHandler("rich:ready", this);
>             },
> 
>@@ -737,6 +742,14 @@
>                 }
>             },
> 
>+            activateResizeListener: function() {
>+                $(window).on(this.resizeEventName, jQuery.proxy(this.updateLayout, this));
>+            },
>+
>+            deActivateResizeListener: function() {
>+                $(window).off(this.resizeEventName);
>+            },
>+
>             contextMenuAttach: function (menu) {
>                 var selector = "[id='" + this.element.id + "'] ";
>                 selector += (typeof menu.options.targetSelector === 'undefined')
>-- 
>1.7.7.6
>

Actions: View | Diff

Attachments on bug 888815: 666245 | 666246 | 666248 | 672114 | 674314 | 674315 | 674316