Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 669945 Details for
Bug 879869
patch to fix mic-e packet editing bug
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
patch to fix mic-e encoding bug
aprsd-2.2.5-15-mic-e.patch2 (text/plain), 1.49 KB, created by
Alan Crosswell
on 2012-12-28 19:19:11 UTC
(
hide
)
Description:
patch to fix mic-e encoding bug
Filename:
MIME Type:
Creator:
Alan Crosswell
Created:
2012-12-28 19:19:11 UTC
Size:
1.49 KB
patch
obsolete
>diff -c -r aprsd-2.2.5-15.orig/src/ax25socket.cpp aprsd-2.2.5-15/src/ax25socket.cpp >*** aprsd-2.2.5-15.orig/src/ax25socket.cpp 2003-05-29 14:26:33.000000000 -0400 >--- aprsd-2.2.5-15/src/ax25socket.cpp 2012-12-28 14:07:25.258153902 -0500 >*************** >*** 288,300 **** > // No rewriting for mic-e frames because aprsd does this later > sprintf ((char*)buf1, "%s>%s%s:", from, to, digis); > l = strlen ((char*)buf1); > for (i = 0; i < len; i++, l++) { >! buf1[l] = (isprint (buf[i])) ? buf[i] : ' '; // keep it clean > } > >- buf1[l++] = 0x0d; >- buf1[l++] = 0x0a; >- > buf1[l] = '\0'; > return; > } >--- 288,303 ---- > // No rewriting for mic-e frames because aprsd does this later > sprintf ((char*)buf1, "%s>%s%s:", from, to, digis); > l = strlen ((char*)buf1); >+ // this "cleanup" introduced a bug as it was checking isprint() and blanking any >+ // characters that didn't pass. The APRS protocol for MIC-E format >+ // includes non-printing characters between 0x1c-0x7f. It's not entirely clear why >+ // we wouldn't just pass the data through with no "cleanup". A different patch was >+ // written for Debian, but I believe that patch to be incorrect as it was dropping >+ // rather than blanking "bad" characters. Similarly, concatenating CRLF is also a bug. > for (i = 0; i < len; i++, l++) { >! buf1[l] = (buf[i] >= 0x1c && buf[i] <= 0x7f) ? buf[i] : ' '; // keep it clean > } > > buf1[l] = '\0'; > return; > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 879869
:
651312
|
651313
|
669945
|
669946
|
746459
|
746460