Attachment 670367 Details for Bug 890417 – php-Analog-review.txt

php-Analog-review.txt

php-Analog-review.txt (text/plain), 8.66 KB, created by Remi Collet on 2012-12-30 10:03:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2012-12-30 10:03:33 UTC

Size: 8.66 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>[x] = Pass
>[!] = Fail
>[-] = Not applicable
>[?] = Not evaluated
>[ ] = Manual review needed
>
>
>Issues:
>=======
>[!]: Requires correct, justified where necessary.
>[!]: Package installs properly.
>     Note: Installation errors (see attachment)
>	php-mongo => php-pecl(mongo)
>[!]: Package complies to the Packaging Guidelines
>	I don't understand version, why 1.0.0.1 ?
>	If post release, should be 1.0.0-1.gitxxx
>	If pre release , should be 1.0.0.1-0.1.gitxxx
>	or justify/explain
>[!]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[!]: %check is present and all tests pass.
>[!]: Rpmlint is run on all installed packages.
>php-Analog.src: E: specfile-error error: Macro % has illegal name (%define)
>	-%global %Mreldate 20121224
>	+%global reldate 20121224
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[-]: %build honors applicable compiler flags or justifies otherwise.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package contains no bundled libraries.
>[x]: Changelog in prescribed format.
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf %{buildroot} present but not required
>[x]: Sources contain only permissible code or content.
>[x]: Each %files section contains %defattr if rpm < 4.4
>     Note: %defattr present but not needed
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package requires other packages for directories it uses.
>[x]: Package uses nothing in %doc for runtime.
>[-]: Package is not known to require ExcludeArch.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[!]: Package complies to the Packaging Guidelines
>[x]: Spec file lacks Packager, Vendor, PreReq tags.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "MIT/X11 (BSD like)", "Unknown or generated". 2 files have unknown
>     license. Detailed output of licensecheck in
>     /home/extras/SPECS/review/889400-php-PHPParser/890417-php-
>     Analog/licensecheck.txt
>[x]: Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: Package do not use a name that already exist
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[!]: Package installs properly.
>     Note: Installation errors (see attachment)
>[x]: Package is not relocatable.
>[!]: Requires correct, justified where necessary.
>[x]: CheckResultdir
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file is legible and written in American English.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: Package contains systemd file(s) if in need.
>[x]: File names are valid UTF-8.
>[x]: Large documentation must go in a -doc subpackage.
>     Note: Documentation size is 40960 bytes in 20 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>PHP:
>[x]: Package requires php-common instead of php.
>
>===== SHOULD items =====
>
>Generic:
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>     Note: Buildroot: present but not needed
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: %clean present but not required
>[!]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Dist tag is present.
>     Note: Multiple Release tags found
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[x]: Package functions as described.
>[-]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[x]: The placement of pkgconfig(.pc) files are correct.
>[x]: SourceX tarball generation or download is documented.
>     Note: Package contains tarball without URL, check comments
>[!]: SourceX / PatchY prefixed with %{name}.
>     Note: Source0 (analog-1.0.0.1-git876d8a3bb.tar.bz2)
>[x]: SourceX is a working URL.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[!]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Spec use %global instead of %define.
>
>===== EXTRA items =====
>
>Generic:
>[!]: Rpmlint is run on all installed packages.
>     Note: Mock build failed
>[x]: Spec file according to URL is the same as in SRPM.
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>     Note:  phpci static analyze results in
>     /home/extras/SPECS/review/889400-php-PHPParser/890417-php-
>     Analog/phpci.log
>
>
>Installation errors
>-------------------
>INFO: mock.py version 1.1.28 starting...
>Start: init plugins
>INFO: selinux enabled
>Finish: init plugins
>Start: run
>Mock Version: 1.1.28
>INFO: Mock Version: 1.1.28
>Start: lock buildroot
>INFO: installing package(s): /home/extras/SPECS/review/889400-php-PHPParser/890417-php-Analog/results/php-Analog-1.0.0.1-1.git876d8a3bb.fc17.noarch.rpm
>ERROR: Command failed: 
> # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-17-x86_64/root/', 'install', '/home/extras/SPECS/review/889400-php-PHPParser/890417-php-Analog/results/php-Analog-1.0.0.1-1.git876d8a3bb.fc17.noarch.rpm', '--setopt=tsflags=nocontexts']
>ErreurÂ : PaquetÂ : php-Analog-1.0.0.1-1.git876d8a3bb.fc17.noarch (/php-Analog-1.0.0.1-1.git876d8a3bb.fc17.noarch)
>             RequiertÂ : php-mongo
> Vous pouvez essayer d'utiliser --skip-broken pour contourner le problÃ¨me
> Vous pouvez essayer d'exÃ©cuterÂ : rpm -Va --nofiles --nodigest
>
>
>
>Rpmlint
>-------
>Checking: php-Analog-1.0.0.1-1.git876d8a3bb.fc17.noarch.rpm
>          php-Analog-1.0.0.1-1.git876d8a3bb.fc17.src.rpm
>php-Analog.noarch: W: spelling-error %description -l en_US configurability -> configuration
>php-Analog.noarch: W: spelling-error %description -l en_US extensibility -> sensibility, extensible
>php-Analog.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee
>php-Analog.noarch: W: spelling-error %description -l en_US syslog -> slog
>php-Analog.src: W: spelling-error %description -l en_US configurability -> configuration
>php-Analog.src: W: spelling-error %description -l en_US extensibility -> sensibility, extensible
>php-Analog.src: W: spelling-error %description -l en_US pre -> per, ore, pee
>php-Analog.src: W: spelling-error %description -l en_US syslog -> slog
>php-Analog.src: E: specfile-error error: Macro % has illegal name (%define)
>php-Analog.src: E: specfile-error error: Macro % has illegal name (%define)
>2 packages and 0 specfiles checked; 2 errors, 8 warnings.
>
>
>
>
>Requires
>--------
>php-Analog-1.0.0.1-1.git876d8a3bb.fc17.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    php-common >= 5.3.0
>    php-curl  
>    php-date  
>    php-hash  
>    php-json  
>    php-mongo  
>    php-pcre  
>    php-spl  
>
>
>
>Provides
>--------
>php-Analog-1.0.0.1-1.git876d8a3bb.fc17.noarch.rpm:
>    
>    php-Analog = 1.0.0.1-1.git876d8a3bb.fc17
>
>
>
>MD5-sum check
>-------------
>
>
>Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
>Buildroot used: fedora-17-x86_64
>Command line :/usr/bin/fedora-review -b 890417

Actions: View

Attachments on bug 890417: 670366 | 670367