Attachment 672268 Details for Bug 833535 – Patch - Fix sparse warning: context imbalance in autofs4_d_automount() different lock contexts for basic block

[patch] Patch - Fix sparse warning: context imbalance in autofs4_d_automount() different lock contexts for basic block

parse-warning-context-imbalance-in-autofs4_d_automount-different-lock-contexts-for-basic-block.patch (text/plain), 1.28 KB, created by Ian Kent on 2013-01-04 00:32:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ian Kent

Created: 2013-01-04 00:32:03 UTC

Size: 1.28 KB

patch

obsolete

>autofs - Fix sparse warning: context imbalance in autofs4_d_automount() different lock contexts for basic block
>
>From: Peter Huewe <peterhuewe@gmx.de>
>
>Sparse complains:
>+ fs/autofs4/root.c:409:9: sparse: context imbalance in
>'autofs4_d_automount' - different lock contexts for basic block
>
>This was introduced by commit
>f55fb0c243 autofs4 - dont clear DCACHE_NEED_AUTOMOUNT on rootless mount
>
>The function autofs4_d_automount can be left with the (&sbi->fs_lock)
>held if sbi->version <= 4 and simple_empty(dentry) == false so the warning seems valid.
>
>--> Add an spin_unlock in this case before we jump to done
>
>Unfortunately compile tested only.
>
>Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
>Acked-by: Ian Kent <raven@themaw.net>
>---
>
> fs/autofs4/root.c |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>
>diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
>index c934476..74a299f 100644
>--- a/fs/autofs4/root.c
>+++ b/fs/autofs4/root.c
>@@ -383,8 +383,10 @@ static struct vfsmount *autofs4_d_automount(struct path *path)
> 				goto done;
> 			}
> 		} else {
>-			if (!simple_empty(dentry))
>+			if (!simple_empty(dentry)) {
>+				spin_unlock(&sbi->fs_lock);
> 				goto done;
>+			}
> 		}
> 		ino->flags |= AUTOFS_INF_PENDING;
> 		spin_unlock(&sbi->fs_lock);

Actions: View | Diff

Attachments on bug 833535: 593444 | 609140 | 610823 | 611990 | 625260 | 636456 | 641908 | 647703 | 647705 | 649476 | 672268 | 672270