Attachment 674402 Details for Bug 892221 – tentative patch to fix the issue

[patch] tentative patch to fix the issue

0001-do-not-use-a-predictable-filename-for-temporary-file.patch (text/plain), 1.20 KB, created by Michael S. on 2013-01-07 22:56:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael S.

Created: 2013-01-07 22:56:30 UTC

Size: 1.20 KB

patch

obsolete

>From 1c31926e2b6dac334c3ae4c00a1cf8ba4c69b83d Mon Sep 17 00:00:00 2001
>From: Michael Scherer <misc@zarb.org>
>Date: Mon, 7 Jan 2013 23:39:25 +0100
>Subject: [PATCH] do not use a predictable filename for temporary file used to
> store data to compare ( RH bugzilla #892221 )
>
>---
> lib/gauntlet_rubyparser.rb | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
>diff --git a/lib/gauntlet_rubyparser.rb b/lib/gauntlet_rubyparser.rb
>index 4463c38..85137f9 100755
>--- a/lib/gauntlet_rubyparser.rb
>+++ b/lib/gauntlet_rubyparser.rb
>@@ -35,18 +35,19 @@ class RubyParserGauntlet < Gauntlet
>   def diff_pp o1, o2
>     require 'pp'
> 
>-    File.open("/tmp/a.#{$$}", "w") do |f|
>-      PP.pp o1, f
>-    end
>+    file_a = Tempfile.new('ruby_parser_a')
>+    PP.pp o1, file_a
>+    file_a.close
>+
>+    file_b = Tempfile.new('ruby_parser_b')
>+    PP.pp o2, file_b
>+    file_b.close
> 
>-    File.open("/tmp/b.#{$$}", "w") do |f|
>-      PP.pp o2, f
>-    end
> 
>-    `diff -u /tmp/a.#{$$} /tmp/b.#{$$}`
>+    `diff -u #{file_a.path} #{file_b.path}`
>   ensure
>-    File.unlink "/tmp/a.#{$$}" rescue nil
>-    File.unlink "/tmp/b.#{$$}" rescue nil
>+    file_a.unlink
>+    file_b.unlink
>   end
> 
>   def broke name, file, msg
>-- 
>1.8.0.2
>

Actions: View | Diff

Attachments on bug 892221: 674402