Attachment 675802 Details for Bug 862862 – ixgbevf: allocate room for the mailbox MSI-X interrupt's name (proposed patch)

[patch] ixgbevf: allocate room for the mailbox MSI-X interrupt's name (proposed patch)

0001-ixgbevf-allocate-room-for-the-mailbox-MSI-X-interrup.patch (text/plain), 1.54 KB, created by Laszlo Ersek on 2013-01-09 19:31:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Laszlo Ersek

Created: 2013-01-09 19:31:38 UTC

Size: 1.54 KB

patch

obsolete

>From 2d44da63d7b9a135ebe8e565de122aac1edc8529 Mon Sep 17 00:00:00 2001
>From: Laszlo Ersek <lersek@redhat.com>
>Date: Wed, 9 Jan 2013 20:22:38 +0100
>Subject: [RHEL5.10 PATCH] ixgbevf: allocate room for the mailbox MSI-X interrupt's name
>
>Without this change, the
>
>  sprintf(adapter->name[vector], "%s:mbx", netdev->name);
>
>statement in ixgbevf_request_msix_irqs() tramples over
>
>- adapter->itr_setting,
>- adapter->eitr_low,
>- adapter->eitr_high,
>- adapter->tx_ring,
>
>dependent on the net_device (interface) name length. For short names the
>problem is (apparently) not catastrophic, because the first three fields
>above seem to influence performance only. The fourth field ("tx_ring") is
>a pointer however, and a long enough iface name (in our testing: at least
>10 non-NUL chars) will cause a crash.
>
>Upstream fixed the problem on the side with commit fa71ae27, hence the
>patch is RHEL-5 specific.
>
>(Andy backported fa71ae27 to RHEL-6 (commit 24a9e7c2).)
>
>Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>---
> drivers/net/ixgbevf/ixgbevf.h |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/ixgbevf/ixgbevf.h b/drivers/net/ixgbevf/ixgbevf.h
>index 79a2a3e..25a389d 100644
>--- a/drivers/net/ixgbevf/ixgbevf.h
>+++ b/drivers/net/ixgbevf/ixgbevf.h
>@@ -178,7 +178,7 @@ struct ixgbevf_q_vector {
> #define NON_Q_VECTORS (OTHER_VECTOR)
> 
> #define MAX_MSIX_Q_VECTORS 2
>-#define MAX_MSIX_COUNT 2
>+#define MAX_MSIX_COUNT (MAX_MSIX_Q_VECTORS + NON_Q_VECTORS)
> 
> #define MIN_MSIX_Q_VECTORS 2
> #define MIN_MSIX_COUNT (MIN_MSIX_Q_VECTORS + NON_Q_VECTORS)
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 862862: 624960 | 629093 | 653948 | 653952 | 663166 | 663204 | 663206 | 672173 | 672220 | 674634 | 674635 | 674871 | 674973 | 675360 | 675802