Attachment 675866 Details for Bug 875255 – fix rate scaling

[patch] fix rate scaling

0001-iwlwifi-audit-singles-frame-from-AGG-queue-in-RS.patch (text/plain), 1.73 KB, created by Emmanuel Grumbach on 2013-01-09 20:49:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emmanuel Grumbach

Created: 2013-01-09 20:49:20 UTC

Size: 1.73 KB

patch

obsolete

>From be5b51b591e517704983201dd39b4af5a0030198 Mon Sep 17 00:00:00 2001
>From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>Date: Wed, 9 Jan 2013 10:20:36 +0200
>Subject: [PATCH] iwlwifi: audit singles frame from AGG queue in RS
>
>The rate scaling won't treat the information in a frame
>with IEEE80211_TX_CTL_AMPDU set if IEEE80211_TX_STAT_AMPDU
>is cleared. But all the frames coming from an AGG tx queue
>have IEEE80211_TX_CTL_AMPDU set, and IEEE80211_TX_STAT_AMPDU
>is set only if the frame was sent in an AMPDU.
>This means that all the data in frames in AGG tx queues that
>aren't sent as an AMPDU is thrown away.
>This is even more harmful when in bad link conditions, the
>frames are sent in an AMPDU and then finally sent as single
>frame. So a lot of failures weren't reported and the rate
>scaling got stuck in high rates leading to very poor
>connectivity.
>
>Fix that by clearing IEEE80211_TX_CTL_AMPDU when the frame
>isn't part of an AMPDU.
>
>Change-Id: I769f79d3d2a4ebcb71af78e7e17a2fb3a12f30f7
>Cc: stable@vger.kernel.org
>Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>---
> drivers/net/wireless/iwlwifi/dvm/tx.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/net/wireless/iwlwifi/dvm/tx.c b/drivers/net/wireless/iwlwifi/dvm/tx.c
>index b21b0a6..6a6f1aa 100644
>--- a/drivers/net/wireless/iwlwifi/dvm/tx.c
>+++ b/drivers/net/wireless/iwlwifi/dvm/tx.c
>@@ -1090,6 +1090,8 @@ static void iwlagn_set_tx_status(struct iwl_priv *priv,
> {
> 	u16 status = le16_to_cpu(tx_resp->status.status);
> 
>+	info->flags &= ~IEEE80211_TX_CTL_AMPDU;
>+
> 	info->status.rates[0].count = tx_resp->failure_frame + 1;
> 	info->flags |= iwl_tx_status_to_mac80211(status);
> 	iwlagn_hwrate_to_tx_control(priv, le32_to_cpu(tx_resp->rate_n_flags),
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 875255: 641873 | 645693 | 675866 | 826743 | 826745