Attachment 676238 Details for Bug 879462 – Fix race of open and suspend in error case

[patch] Fix race of open and suspend in error case

0001-uvcvideo-Fix-race-of-open-and-suspend-in-error-case.patch (text/plain), 1.39 KB, created by Laurent Pinchart on 2013-01-10 10:48:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Laurent Pinchart

Created: 2013-01-10 10:48:55 UTC

Size: 1.39 KB

patch

obsolete

>From a91f45918423dad5a5a2d029635786d0f173bb9e Mon Sep 17 00:00:00 2001
>From: Oliver Neukum <oliver@neukum.org>
>Date: Thu, 10 Jan 2013 11:04:55 +0100
>Subject: [PATCH] uvcvideo: Fix race of open and suspend in error case
>
>Ming Lei reported:
>
>IMO, there is a minor fault in the error handling path of
>uvc_status_start() inside uvc_v4l2_open(), and the 'users' count should
>have been decreased before usb_autopm_put_interface(). In theory, a [URB
>resubmission] warning can be triggered when the device is opened just
>between usb_autopm_put_interface() and atomic_dec(&stream->dev->users).
>
>The fix is trivial.
>
>Reported-by: Ming Lei <tom.leiming@gmail.com>
>Signed-off-by: Oliver Neukum <oneukum@suse.de>
>Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>---
> drivers/media/usb/uvc/uvc_v4l2.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c
>index 68d59b5..fb1d076 100644
>--- a/drivers/media/usb/uvc/uvc_v4l2.c
>+++ b/drivers/media/usb/uvc/uvc_v4l2.c
>@@ -501,8 +501,8 @@ static int uvc_v4l2_open(struct file *file)
> 	if (atomic_inc_return(&stream->dev->users) == 1) {
> 		ret = uvc_status_start(stream->dev);
> 		if (ret < 0) {
>-			usb_autopm_put_interface(stream->dev->intf);
> 			atomic_dec(&stream->dev->users);
>+			usb_autopm_put_interface(stream->dev->intf);
> 			kfree(handle);
> 			return ret;
> 		}
>-- 
>1.7.8.6
>

Actions: View | Diff

Attachments on bug 879462: 675111 | 676238