Attachment 676697 Details for Bug 894100 – fedora-review results

fedora-review results

php-pear-File-Fstab-review.txt (text/plain), 6.62 KB, created by Johan Cwiklinski on 2013-01-11 07:40:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Johan Cwiklinski

Created: 2013-01-11 07:40:09 UTC

Size: 6.62 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>[x] = Pass
>[!] = Fail
>[-] = Not applicable
>[?] = Not evaluated
>[ ] = Manual review needed
>
>
>Issues:
>=======
>[!]: Package requires php-common instead of php.
>See: http://fedoraproject.org/wiki/Packaging:PHP
>
>
>===== MUST items =====
>
>Generic:
>[ ]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[ ]: %build honors applicable compiler flags or justifies otherwise.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[ ]: Package contains no bundled libraries.
>[ ]: Changelog in prescribed format.
>[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf %{buildroot} present but not required
>[ ]: Sources contain only permissible code or content.
>[ ]: Each %files section contains %defattr if rpm < 4.4
>     Note: %defattr present but not needed
>[ ]: Macros in Summary, %description expandable at SRPM build time.
>[ ]: Package contains desktop file if it is a GUI application.
>[ ]: Development files must be in a -devel package
>[ ]: Package requires other packages for directories it uses.
>[ ]: Package uses nothing in %doc for runtime.
>[ ]: Package is not known to require ExcludeArch.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[ ]: Package complies to the Packaging Guidelines
>[x]: Spec file lacks Packager, Vendor, PreReq tags.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[ ]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "PHP (v3.0)". 1 files have unknown license. Detailed output of
>     licensecheck in /home/builder/894100-php-pear-File-Fstab/licensecheck.txt
>[ ]: Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: Package is named using only allowed ASCII characters.
>[ ]: Package is named according to the Package Naming Guidelines.
>[ ]: Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: Package do not use a name that already exist
>[ ]: Package obeys FHS, except libexecdir and /usr/target.
>[ ]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[ ]: Package must own all directories that it creates.
>[ ]: Package does not own files or directories owned by other packages.
>[x]: Package installs properly.
>[ ]: Package is not relocatable.
>[ ]: Requires correct, justified where necessary.
>[x]: CheckResultdir
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[ ]: Spec file is legible and written in American English.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[ ]: Package contains systemd file(s) if in need.
>[x]: File names are valid UTF-8.
>[ ]: Large documentation must go in a -doc subpackage.
>     Note: Documentation size is 10240 bytes in 2 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>PHP:
>[!]: Package requires php-common instead of php.
>
>===== SHOULD items =====
>
>Generic:
>[x]: Reviewer should test that the package builds in mock.
>[ ]: Buildroot is not present
>     Note: Buildroot: present but not needed
>[ ]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: %clean present but not required
>[ ]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Dist tag is present.
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[ ]: Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[ ]: Package functions as described.
>[ ]: Latest version is packaged.
>[ ]: Package does not include license text files separate from upstream.
>[x]: The placement of pkgconfig(.pc) files are correct.
>[ ]: Scriptlets must be sane, if used.
>[x]: SourceX tarball generation or download is documented.
>[!]: SourceX / PatchY prefixed with %{name}.
>     Note: Source0 (File_Fstab-2.0.3.tgz) Source1 (LICENSE)
>[x]: SourceX is a working URL.
>[ ]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[ ]: %check is present and all tests pass.
>[ ]: Packages should try to preserve timestamps of original installed files.
>[x]: Spec use %global instead of %define.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Spec file according to URL is the same as in SRPM.
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>
>
>Rpmlint
>-------
>Checking: php-pear-File-Fstab-2.0.3-1.fc19.noarch.rpm
>          php-pear-File-Fstab-2.0.3-1.fc19.src.rpm
>php-pear-File-Fstab.noarch: W: spelling-error %description -l en_US blockdev -> blockade
>php-pear-File-Fstab.src: W: spelling-error %description -l en_US blockdev -> blockade
>2 packages and 0 specfiles checked; 0 errors, 2 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-pear-File-Fstab
>php-pear-File-Fstab.noarch: W: spelling-error %description -l en_US blockdev -> blockade
>1 packages and 0 specfiles checked; 0 errors, 1 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-pear-File-Fstab-2.0.3-1.fc19.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    /bin/sh
>    /usr/bin/pear
>    php-pcre
>    php-pear(PEAR)
>
>
>
>Provides
>--------
>php-pear-File-Fstab-2.0.3-1.fc19.noarch.rpm:
>    
>    php-pear(File_Fstab) = 2.0.3
>    php-pear-File-Fstab = 2.0.3-1.fc19
>
>
>
>MD5-sum check
>-------------
>http://pear.php.net/get/File_Fstab-2.0.3.tgz :
>  CHECKSUM(SHA256) this package     : f4a359b1d0426aae0c2ea0775101905e0be020a66ca3acae0f7864dbf3a7ff17
>  CHECKSUM(SHA256) upstream package : f4a359b1d0426aae0c2ea0775101905e0be020a66ca3acae0f7864dbf3a7ff17
>
>
>Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
>Buildroot used: fedora-rawhide-x86_64
>Command line :/usr/bin/fedora-review -b 894100 -m fedora-rawhide-x86_64

Actions: View

Attachments on bug 894100: 676697