Attachment 684251 Details for Bug 901594 – php-password-compat-review.txt

php-password-compat-review.txt

php-password-compat-review.txt (text/plain), 6.85 KB, created by Remi Collet on 2013-01-21 12:21:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2013-01-21 12:21:12 UTC

Size: 6.85 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>[x] = Pass
>[!] = Fail
>[-] = Not applicable
>[?] = Not evaluated
>[ ] = Manual review needed
>
>
>[!]: Run phpci static analyze on all php files.
>	phpci reports REQUIRED PHP 5.5.0-dev (MIN) which is, of course a false positive.
>[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>	Could be droped as other EL-5 stuff not present
>[!]: Description "PHP password_* function for 5.3 and 5.4"
>	probably "PHP" missing"
>[!]: Comment in %check (not version 1.4.4)
>	OK (30 tests, 30 assertions)
>[!]: test in PHP include_path
>	Please move to /usr/share/tests/%{name}
>	NB/ need to own /usr/share/tests or require php-pear
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[-]: %build honors applicable compiler flags or justifies otherwise.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package contains no bundled libraries.
>[x]: Changelog in prescribed format.
>[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf %{buildroot} present but not required
>[x]: Sources contain only permissible code or content.
>[x]: Each %files section contains %defattr if rpm < 4.4
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package requires other packages for directories it uses.
>[x]: Package uses nothing in %doc for runtime.
>[-]: Package is not known to require ExcludeArch.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package complies to the Packaging Guidelines
>[x]: Spec file lacks Packager, Vendor, PreReq tags.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "Unknown or generated". 1 files have unknown license. Detailed output of
>     licensecheck in /home/extras/SPECS/review/901594-php-password-
>     compat/licensecheck.txt
>[x]: Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: Package do not use a name that already exist
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: Package installs properly.
>[x]: Package is not relocatable.
>[x]: Requires correct, justified where necessary.
>[x]: CheckResultdir
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: No rpmlint messages.
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file is legible and written in American English.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: Package contains systemd file(s) if in need.
>[x]: File names are valid UTF-8.
>[x]: Large documentation must go in a -doc subpackage.
>     Note: Documentation size is 10240 bytes in 3 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>PHP:
>[x]: Package requires php-common instead of php.
>
>===== SHOULD items =====
>
>Generic:
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[-]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Dist tag is present.
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>	git snapshot
>[x]: Package does not include license text files separate from upstream.
>[x]: The placement of pkgconfig(.pc) files are correct.
>[x]: SourceX tarball generation or download is documented.
>[!]: SourceX / PatchY prefixed with %{name}.
>     Note: Source0 (password_compat-1.0.0-58151cf.tar.gz)
>[x]: SourceX is a working URL.
>[x]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[x]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Spec use %global instead of %define.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: No rpmlint messages.
>[x]: Spec file according to URL is the same as in SRPM.
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>
>PHP:
>[!]: Run phpci static analyze on all php files.
>     Note: phpci static
>     analyze results in /home/extras/SPECS/review/901594-php-password-
>     compat/phpci.log
>
>
>Rpmlint
>-------
>Checking: php-password-compat-1.0.0-1.git58151cf.fc17.noarch.rpm
>          php-password-compat-1.0.0-1.git58151cf.fc17.src.rpm
>2 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-password-compat
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-password-compat-1.0.0-1.git58151cf.fc17.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    php-common >= 5.3.7
>    php-mcrypt  
>    php-openssl  
>    php-pcre  
>
>
>
>Provides
>--------
>php-password-compat-1.0.0-1.git58151cf.fc17.noarch.rpm:
>    
>    php-password-compat = 1.0.0-1.git58151cf.fc17
>
>
>
>MD5-sum check
>-------------
>https://github.com/ircmaxell/password_compat/archive/58151cf24e73119576c2a016393120f9c146448b/password_compat-1.0.0-58151cf.tar.gz :
>  CHECKSUM(SHA256) this package     : aecfa942375773220983228f31acf4e85e89a1344ebc79f8b79afef11588ec0f
>  CHECKSUM(SHA256) upstream package : aecfa942375773220983228f31acf4e85e89a1344ebc79f8b79afef11588ec0f
>
>
>Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
>Buildroot used: fedora-17-x86_64
>Command line :/usr/bin/fedora-review -b 901594

Flags:

fedora: review?

Actions: View

Attachments on bug 901594: 684250 | 684251