Attachment 684276 Details for Bug 901611 – php-atoum-review.txt

php-atoum-review.txt

php-atoum-review.txt (text/plain), 7.74 KB, created by Remi Collet on 2013-01-21 13:11:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2013-01-21 13:11:12 UTC

Size: 7.74 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>[x] = Pass
>[!] = Fail
>[-] = Not applicable
>[?] = Not evaluated
>[ ] = Manual review needed
>
>[!]: Requires correct, justified where necessary.
>	Missing: php-xml
>	Requires: /usr/bin/env instead of /usr/bin/php
>	=> fix the shebang in /usr/bin/atoum
>[!]: %check is present and all tests pass.
>	%check
>	cd tests/units
>	echo "date.timezone=UTC" >php.ini
>	export PHPRC=$(pwd)/php.ini
>	php runner.php --directories .
>[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>	Clean as other EL-5 stuff not present
>[!]: License field in the package spec file matches the actual license.
>	COPYING file is BSD (3 clauses), not MIT
>	=> probably worth asking upstream to add a license "header" in all files
>[!]: Package complies to the Packaging Guidelines
>	Non-PEAR PHP software which provides shared libraries should put its PHP source 
>	files for such shared libraries in a subfolder of /usr/share/php.
>	=> this is not a library, so should rather use /usr/share/foo
>	(perhaps "classes" could go in /usr/share/php, which is in PHP include_path)
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[-]: %build honors applicable compiler flags or justifies otherwise.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package contains no bundled libraries.
>[x]: Changelog in prescribed format.
>[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf %{buildroot} present but not required
>[x]: Sources contain only permissible code or content.
>[x]: Each %files section contains %defattr if rpm < 4.4
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package requires other packages for directories it uses.
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package is not known to require ExcludeArch.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[!]: Package complies to the Packaging Guidelines
>[x]: Spec file lacks Packager, Vendor, PreReq tags.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[!]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "Unknown or generated". 1 files have unknown license. Detailed output of
>     licensecheck in /home/extras/SPECS/review/901611-php-
>     atoum/licensecheck.txt
>[x]: Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: Package do not use a name that already exist
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: Package installs properly.
>[x]: Package is not relocatable.
>[!]: Requires correct, justified where necessary.
>[x]: CheckResultdir
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file is legible and written in American English.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: Package contains systemd file(s) if in need.
>[x]: File names are valid UTF-8.
>[x]: Large documentation must go in a -doc subpackage.
>     Note: Documentation size is 30720 bytes in 6 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>PHP:
>[x]: Package requires php-common instead of php.
>
>===== SHOULD items =====
>
>Generic:
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[ ]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Dist tag is present.
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[!]: Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>	git snapshot
>[x]: Package does not include license text files separate from upstream.
>[x]: The placement of pkgconfig(.pc) files are correct.
>[x]: SourceX tarball generation or download is documented.
>[!]: SourceX / PatchY prefixed with %{name}.
>     Note: Source0 (atoum-0-724d3ee.tar.gz)
>[x]: SourceX is a working URL.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[!]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Spec use %global instead of %define.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Spec file according to URL is the same as in SRPM.
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>     Note: phpci static analyze results in
>     /home/extras/SPECS/review/901611-php-atoum/phpci.log
>
>
>Rpmlint
>-------
>Checking: php-atoum-0-0.2.git724d3ee.fc17.noarch.rpm
>          php-atoum-0-0.2.git724d3ee.fc17.src.rpm
>php-atoum.noarch: W: spelling-error %description -l en_US natively -> naively, negatively, tentatively
>php-atoum.noarch: W: no-manual-page-for-binary atoum
>php-atoum.src: W: spelling-error %description -l en_US natively -> naively, negatively, tentatively
>2 packages and 0 specfiles checked; 0 errors, 3 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-atoum
>php-atoum.noarch: W: spelling-error %description -l en_US natively -> naively, negatively, tentatively
>php-atoum.noarch: W: no-manual-page-for-binary atoum
>1 packages and 0 specfiles checked; 0 errors, 2 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-atoum-0-0.2.git724d3ee.fc17.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    /usr/bin/env  
>    php-common >= 5.3.3
>    php-date  
>    php-dom  
>    php-hash  
>    php-json  
>    php-mbstring  
>    php-pcre  
>    php-pecl(Xdebug) >= 2.2.1
>    php-spl  
>    php-tokenizer  
>
>
>
>Provides
>--------
>php-atoum-0-0.2.git724d3ee.fc17.noarch.rpm:
>    
>    atoum = 0-0.2.git724d3ee.fc17
>    php-atoum = 0-0.2.git724d3ee.fc17
>
>
>
>MD5-sum check
>-------------
>https://github.com/atoum/atoum/archive/724d3ee117695b8cce3b990cd3cb9fae3cec44a3/atoum-0-724d3ee.tar.gz :
>  CHECKSUM(SHA256) this package     : ffc96376a06e263acb66f9614b763f59e6697712a752cbe3136b6c09983f4df5
>  CHECKSUM(SHA256) upstream package : ffc96376a06e263acb66f9614b763f59e6697712a752cbe3136b6c09983f4df5
>
>
>Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
>Buildroot used: fedora-17-x86_64
>Command line :/usr/bin/fedora-review -b 901611

Actions: View

Attachments on bug 901611: 684275 | 684276