Attachment 691639 Details for Bug 906849 – Patch for MokManager

[patch] Patch for MokManager

0002-MokManager-Omit-16-byte-padding-when-computing-finge.patch (text/plain), 1.10 KB, created by Daniel Dadap on 2013-02-01 17:07:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Dadap

Created: 2013-02-01 17:07:50 UTC

Size: 1.10 KB

patch

obsolete

>From e9d75aae2ab3210253d7b94565423e49ad7e1cf2 Mon Sep 17 00:00:00 2001
>From: Daniel Dadap <ddadap@nvidia.com>
>Date: Thu, 31 Jan 2013 08:22:38 -0600
>Subject: [PATCH 2/2] MokManager: Omit 16 byte padding when computing
> fingerprint
>
>SignatureSize is 16 bytes larger than the actual certificate size,
>per the UEFI spec, but this larger size shouldn't be used to compute
>the SHA1 fingerprint of an X.509 certificate, since it causes extra
>data, besides the certificate, to be hashed.
>
>In MokManager, subtract 16 from MokSize when passing the size to
>get_sha1sum(), to avoid hashing the extra data.
>
>Signed-off-by: Daniel Dadap <ddadap@nvidia.com>
>---
> MokManager.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/MokManager.c b/MokManager.c
>index 5802d27..f3d9b2f 100644
>--- a/MokManager.c
>+++ b/MokManager.c
>@@ -328,7 +328,7 @@ static void show_mok_info (void *Mok, UINTN MokSize)
> 			return;
> 		}
> 
>-		efi_status = get_sha1sum(Mok, MokSize, hash);
>+		efi_status = get_sha1sum(Mok, MokSize - 16, hash);
> 
> 		if (efi_status != EFI_SUCCESS) {
> 			Print(L"Failed to compute MOK fingerprint\n");
>-- 
>1.7.10.4
>

Actions: View | Diff

Attachments on bug 906849: 691638 | 691639