Attachment 694979 Details for Bug 905484 – Patch for Ncat's testsuite to reflect changes in behaviour

[patch] Patch for Ncat's testsuite to reflect changes in behaviour

0001-Ncat-Test-for-server-client-EOF-issue.patch (text/plain), 1.89 KB, created by Tomáš Hozza on 2013-02-08 08:09:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomáš Hozza

Created: 2013-02-08 08:09:50 UTC

Size: 1.89 KB

patch

obsolete

>From 210a1565e304c1112fcc2ed9f1f0a5e9bc874d3b Mon Sep 17 00:00:00 2001
>From: Tomas Hozza <thozza@redhat.com>
>Date: Fri, 8 Feb 2013 09:03:07 +0100
>Subject: [PATCH] Ncat: Test for server->client EOF issue
>
>Added new test "Server shutdown()s connection when reading EOF (client
>with --recv-only)" to test if client shutdown on receiving EOF
>if run with --recv-only.
>
>Modified test "Server shutdown()s connection when reading EOF" to
>"Server shutdown()s connection when reading EOF (client without
>--recv-only)" to reflect fixed behaviour of the client if --recv-only
>is not used.
>
>Signed-off-by: Tomas Hozza <thozza@redhat.com>
>---
> ncat/test/ncat-test.pl | 19 +++++++++++++++++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
>diff --git a/ncat/test/ncat-test.pl b/ncat/test/ncat-test.pl
>index 58d0c0e..4c39b43 100755
>--- a/ncat/test/ncat-test.pl
>+++ b/ncat/test/ncat-test.pl
>@@ -757,7 +757,7 @@ server_client_test "Client shutdown()s connection when reading EOF",
> };
> kill_children;
> 
>-server_client_test "Server shutdown()s connection when reading EOF",
>+server_client_test "Server shutdown()s connection when reading EOF (client without --recv-only)",
> [], [], sub {
> 	my $resp;
> 
>@@ -768,7 +768,22 @@ server_client_test "Server shutdown()s connection when reading EOF",
> 	close($s_in);
> 
> 	$resp = timeout_read($c_out);
>-	!defined($resp) or die "Client didn't get EOF (got \"$resp\")";
>+	$resp eq "" or die "Client didn't get EOF (got \"$resp\")";
>+};
>+kill_children;
>+
>+server_client_test "Server shutdown()s connection when reading EOF (client with --recv-only)",
>+[], ["--recv-only"], sub {
>+	my $resp;
>+
>+	syswrite($s_in, "abc\n");
>+	$resp = timeout_read($c_out) or die "Read timeout";
>+	$resp eq "abc\n" or die "Client got \"$resp\", not \"abc\\n\"";
>+
>+	close($s_in);
>+
>+	$resp = timeout_read($c_out);
>+	!defined($resp) or die "Client didn't get EOF and didn't exit (got \"$resp\")";
> };
> kill_children;
> 
>-- 
>1.8.1.2
>

Actions: View | Diff

Attachments on bug 905484: 694300 | 694979