Attachment 695858 Details for Bug 892283 – Quick fix patch that solves this immediate problem.

[patch] Quick fix patch that solves this immediate problem.

taglib-1.8.fix.patch (text/plain), 1.44 KB, created by Tim Wegener on 2013-02-10 17:31:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Wegener

Created: 2013-02-10 17:31:19 UTC

Size: 1.44 KB

patch

obsolete

>diff -Naur taglib-1.8/taglib/ape/apefile.cpp taglib-1.8.fix/taglib/ape/apefile.cpp
>--- taglib-1.8/taglib/ape/apefile.cpp	2012-09-07 03:33:15.000000000 +0930
>+++ taglib-1.8.fix/taglib/ape/apefile.cpp	2013-02-11 03:38:43.961495518 +1030
>@@ -242,6 +242,9 @@
> 
> void APE::File::read(bool readProperties, Properties::ReadStyle /* propertiesStyle */)
> {
>+  if(!isValid())
>+    return;
>+
>   // Look for an ID3v1 tag
> 
>   d->ID3v1Location = findID3v1();
>diff -Naur taglib-1.8/taglib/ogg/speex/speexfile.cpp taglib-1.8.fix/taglib/ogg/speex/speexfile.cpp
>--- taglib-1.8/taglib/ogg/speex/speexfile.cpp	2012-09-07 03:33:15.000000000 +0930
>+++ taglib-1.8.fix/taglib/ogg/speex/speexfile.cpp	2013-02-11 03:39:40.536925400 +1030
>@@ -103,6 +103,9 @@
> 
> void Speex::File::read(bool readProperties, Properties::ReadStyle propertiesStyle)
> {
>+  if(!isValid())
>+    return;
>+
>   ByteVector speexHeaderData = packet(0);
> 
>   if(!speexHeaderData.startsWith("Speex   ")) {
>diff -Naur taglib-1.8/taglib/ogg/vorbis/vorbisfile.cpp taglib-1.8.fix/taglib/ogg/vorbis/vorbisfile.cpp
>--- taglib-1.8/taglib/ogg/vorbis/vorbisfile.cpp	2012-09-07 03:33:15.000000000 +0930
>+++ taglib-1.8.fix/taglib/ogg/vorbis/vorbisfile.cpp	2013-02-11 03:38:04.296194126 +1030
>@@ -121,6 +121,9 @@
> 
> void Vorbis::File::read(bool readProperties, Properties::ReadStyle propertiesStyle)
> {
>+  if(!isValid())
>+    return;
>+
>   ByteVector commentHeaderData = packet(1);
> 
>   if(commentHeaderData.mid(0, 7) != vorbisCommentHeaderID) {

Actions: View | Diff

Attachments on bug 892283: 673308 | 673309 | 673310 | 673311 | 673312 | 673313 | 673314 | 673315 | 673316 | 673317 | 673318 | 673319 | 673320 | 695858