Attachment 695975 Details for Bug 909325 – Patch for DEADCODE-CWE-561 bug

[patch] Patch for DEADCODE-CWE-561 bug

0004-DEADCODE-CWE-561.patch (text/plain), 1.09 KB, created by Tomáš Hozza on 2013-02-11 07:26:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomáš Hozza

Created: 2013-02-11 07:26:47 UTC

Size: 1.09 KB

patch

obsolete

>From d8638a83edb2ab42adaa8a77f74d350095ce281f Mon Sep 17 00:00:00 2001
>From: Tomas Hozza <thozza@redhat.com>
>Date: Fri, 8 Feb 2013 15:58:40 +0100
>Subject: [PATCH 4/4] DEADCODE (CWE-561)
>
>Coverity output:
>bsd-finger-0.17/finger/net.c:173: assignment: Assigning: "ateol" = "1".
>bsd-finger-0.17/finger/net.c:178: assignment: Assigning: "ateol" = "1".
>bsd-finger-0.17/finger/net.c:191: const: At condition "ateol", the value
>of "ateol" must be equal to 1.
>bsd-finger-0.17/finger/net.c:191: dead_error_condition: The condition
>"!ateol" cannot be true.
>bsd-finger-0.17/finger/net.c:191: dead_error_line: Execution cannot
>reach this statement "xputc(10);".
>
>Signed-off-by: Tomas Hozza <thozza@redhat.com>
>---
> finger/net.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/finger/net.c b/finger/net.c
>index d273432..157090f 100644
>--- a/finger/net.c
>+++ b/finger/net.c
>@@ -183,7 +183,10 @@ void netfinger(const char *name) {
> 			/* don't print */
> 		}
> 		else {
>-			if (c == '\n') ateol = 1;
>+			if (c == '\n')
>+				ateol = 1;
>+			else
>+				ateol = 0;
> 			sawret = 0;
> 			xputc(c);
> 		}
>-- 
>1.8.1.2
>

Actions: View | Diff

Attachments on bug 909325: 695130 | 695972 | 695973 | 695974 | 695975