Attachment 697946 Details for Bug 910354 – patch from Vojtech [ActionButton is now UiCommandButton]

[patch] patch from Vojtech [ActionButton is now UiCommandButton]

ActionButton-is-now-UiCommandButton.patch (text/plain), 1.95 KB, created by Einav Cohen on 2013-02-15 18:53:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Einav Cohen

Created: 2013-02-15 18:53:19 UTC

Size: 1.95 KB

patch

obsolete

>diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionButton.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionButton.java
>index 0bd5718..02507d0 100644
>--- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionButton.java
>+++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionButton.java
>@@ -1,10 +1,10 @@
> package org.ovirt.engine.ui.common.widget.action;
> 
>-import com.google.gwt.event.dom.client.ClickHandler;
>-import com.google.gwt.event.shared.HandlerRegistration;
>+import org.ovirt.engine.ui.common.widget.AbstractUiCommandButton;
>+
> import com.google.gwt.safehtml.shared.SafeHtml;
> import com.google.gwt.uibinder.client.UiField;
>-import com.google.gwt.user.client.ui.Composite;
>+import com.google.gwt.user.client.ui.ButtonBase;
> import com.google.gwt.user.client.ui.ToggleButton;
> 
> /**
>@@ -15,7 +15,7 @@ import com.google.gwt.user.client.ui.ToggleButton;
>  * <li>{@link #button} widget representing the action button
>  * </ul>
>  */
>-public abstract class AbstractActionButton extends Composite implements ActionButton {
>+public abstract class AbstractActionButton extends AbstractUiCommandButton implements ActionButton {
> 
>     @UiField
>     public ToggleButton button;
>@@ -32,11 +32,6 @@ public abstract class AbstractActionButton extends Composite implements ActionBu
>     }
> 
>     @Override
>-    public HandlerRegistration addClickHandler(ClickHandler handler) {
>-        return button.addClickHandler(handler);
>-    }
>-
>-    @Override
>     public boolean isEnabled() {
>         return button.isEnabled();
>     }
>@@ -56,4 +51,9 @@ public abstract class AbstractActionButton extends Composite implements ActionBu
>         return button;
>     }
> 
>+    @Override
>+    protected ButtonBase getButtonWidget() {
>+        return button;
>+    }
>+
> }

Actions: View | Diff

Attachments on bug 910354: 697946