Attachment 705043 Details for Bug 871603 – ccs_tool: fix ccs_edit example (cont'd)

[patch] ccs_tool: fix ccs_edit example (cont'd)

ccs_tool-fix-ccs_edit-example-cont-d.patch (text/plain), 2.78 KB, created by Jan Pokorný [poki] on 2013-03-04 15:37:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Pokorný [poki]

Created: 2013-03-04 15:37:51 UTC

Size: 2.78 KB

patch

obsolete

>From b64c3f41962fcde3d18bce3b6ae46e6e315eb273 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Jan=20Pokorn=C3=BD?= <jpokorny@redhat.com>
>Date: Mon, 4 Mar 2013 16:28:08 +0100
>Subject: [PATCH] ccs_tool: fix ccs_edit example (cont'd)
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>As already discussed at [bug 869735], "passwd" as a correct parameter
>denoting password.  As follow-up of referencing (it is really just a
>name reference to a custom-named fence device using specific agent,
>not a reference to this agent itself) WTI fencing, use "port" rather
>than "ipport" as "ipport" is usually a shared per-device configuration
>and what changes is particular per-node port.
>
>Also fix the incorrect example with printing configuration to stdout.
>
>[bug 869735] https://bugzilla.redhat.com/show_bug.cgi?id=869735
>
>Resolves: rhbz#871603
>Related: rhbz#869735
>
>Signed-off-by: Jan PokornÃ½ <jpokorny@redhat.com>
>---
> config/tools/ccs_tool/editconf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/config/tools/ccs_tool/editconf.c b/config/tools/ccs_tool/editconf.c
>index c4dcb9c..22fa9aa 100644
>--- a/config/tools/ccs_tool/editconf.c
>+++ b/config/tools/ccs_tool/editconf.c
>@@ -100,7 +100,7 @@ static void create_usage(const char *name)
> 	  "\n"
> 	  "eg:\n"
> 	  "  ccs_tool create MyCluster\n"
>-	  "  ccs_tool addfence apc fence_apc ipaddr=apc.domain.net login=apc password=apc\n"
>+	  "  ccs_tool addfence apc fence_apc ipaddr=apc.domain.net login=apc passwd=apc\n"
> 	  "  ccs_tool addnode node1 -n 1 -f apc port=1\n"
> 	  "  ccs_tool addnode node2 -n 2 -f apc port=2\n"
> 	  "  ccs_tool addnode node3 -n 3 -f apc port=3\n"
>@@ -217,7 +217,7 @@ static void addnode_usage(const char *name)
> 	fprintf(stderr, " -n --nodeid        Nodeid (required)\n");
> 	fprintf(stderr, " -v --votes         Number of votes for this node (default 1)\n");
> 	fprintf(stderr, " -a --altname       Alternative name/interface for multihomed hosts\n");
>-	fprintf(stderr, " -f --fence_type    Type of fencing to use\n");
>+	fprintf(stderr, " -f --fence_type    Name reference of fencing to use\n");
> 	config_usage(1);
> 	help_usage();
> 
>@@ -225,10 +225,10 @@ static void addnode_usage(const char *name)
> 	fprintf(stderr, "Examples:\n");
> 	fprintf(stderr, "\n");
> 	fprintf(stderr, "Add a new node to default configuration file:\n");
>-	fprintf(stderr, "  %s %s newnode1 -n 1 -f wti ipaddr=newnode\n", prog_name, name);
>+	fprintf(stderr, "  %s %s newnode1 -n 1 -f wti7 port=1\n", prog_name, name);
> 	fprintf(stderr, "\n");
> 	fprintf(stderr, "Add a new node and dump config file to stdout rather than save it\n");
>-	fprintf(stderr, "  %s %s newnode2 -n 2 -f apc -o- newnode.temp.net port=1\n", prog_name, name);
>+	fprintf(stderr, "  %s %s -o- newnode2 -n 2 -f apc port=1\n", prog_name, name);
> 
> 	exit(0);
> }
>-- 
>1.7.11.7
>

Actions: View | Diff

Attachments on bug 871603: 705043