Attachment 706216 Details for Bug 918661 – this patch fixes the problem

[patch] this patch fixes the problem

0001-vbo-fix-crash-found-with-shared-display-lists.patch (text/plain), 1.32 KB, created by Brian Paul on 2013-03-06 19:24:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brian Paul

Created: 2013-03-06 19:24:28 UTC

Size: 1.32 KB

patch

obsolete

>From 64f9d3ee0113c0fe502f33914603814f4a98326a Mon Sep 17 00:00:00 2001
>From: Brian Paul <brianp@vmware.com>
>Date: Wed, 6 Mar 2013 12:08:17 -0700
>Subject: [PATCH] vbo: fix crash found with shared display lists
>
>This fixes a crash when a display list is created in one context
>but executed from a second one.  The vbo_save_context::vertex_store
>memeber will be NULL if we never created a display list with the
>context.  Just check for that before dereferencing the pointer.
>
>Fixes http://bugzilla.redhat.com/show_bug.cgi?id=918661
>
>Note: This is a candidate for the stable branches.
>---
> src/mesa/vbo/vbo_save_draw.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/src/mesa/vbo/vbo_save_draw.c b/src/mesa/vbo/vbo_save_draw.c
>index efb386e..f5b5c41 100644
>--- a/src/mesa/vbo/vbo_save_draw.c
>+++ b/src/mesa/vbo/vbo_save_draw.c
>@@ -253,7 +253,7 @@ vbo_save_playback_vertex_list(struct gl_context *ctx, void *data)
>    struct vbo_save_context *save = &vbo_context(ctx)->save;
>    GLboolean remap_vertex_store = GL_FALSE;
> 
>-   if (save->vertex_store->buffer) {
>+   if (save->vertex_store && save->vertex_store->buffer) {
>       /* The vertex store is currently mapped but we're about to replay
>        * a display list.  This can happen when a nested display list is
>        * being build with GL_COMPILE_AND_EXECUTE.
>-- 
>1.7.3.4
>

Actions: View | Diff

Attachments on bug 918661: 706216