Attachment 710779 Details for Bug 913751 – Patch for the FreeIPA side of the issue

[patch] Patch for the FreeIPA side of the issue

freeipa-sbose-0109-pa-pwd-extop-do-not-use-dn-until-it-is-really-set.patch (text/plain), 2.39 KB, created by Sumit Bose on 2013-03-15 17:32:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sumit Bose

Created: 2013-03-15 17:32:55 UTC

Size: 2.39 KB

patch

obsolete

>From 6e7ef35195ab0e9b93b3b937125c3f9e285219de Mon Sep 17 00:00:00 2001
>From: Sumit Bose <sbose@redhat.com>
>Date: Fri, 22 Feb 2013 09:40:35 +0100
>Subject: [PATCH] pa-pwd-extop: do not use dn until it is really set
>
>---
> .../ipa-pwd-extop/ipa_pwd_extop.c                  | 40 +++++++++++-----------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
>diff --git a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
>index 974eda31889109de80a263d1715e3a194ae431ef..b64084e9d503733a797dacfb06471ad580a0c886 100644
>--- a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
>+++ b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
>@@ -240,26 +240,6 @@ static int ipapwd_chpwop(Slapi_PBlock *pb, struct ipapwd_krbcfg *krbcfg)
> 	}
> 
> parse_req_done:
>-
>-	if (usetxn) {
>-                Slapi_DN *sdn = slapi_sdn_new_dn_byref(dn);
>-                Slapi_Backend *be = slapi_be_select(sdn);
>-                slapi_sdn_free(&sdn);
>-                if (be) {
>-			chpwop_pb = slapi_pblock_new();
>-			if (slapi_pblock_set(chpwop_pb, SLAPI_BACKEND, be)) {
>-				LOG_FATAL("slapi_pblock_set failed!\n");
>-				rc = LDAP_OPERATIONS_ERROR;
>-				goto free_and_return;
>-			}
>-			rc = slapi_back_transaction_begin(chpwop_pb);
>-			if (rc) {
>-				LOG_FATAL("failed to start transaction\n");
>-			}
>-		} else {
>-			LOG_FATAL("failed to get be backend from %s\n", dn);
>-		}
>-	}
> 	/* Uncomment for debugging, otherwise we don't want to leak the
> 	 * password values into the log... */
> 	/* LDAPDebug( LDAP_DEBUG_ARGS, "passwd: dn (%s), oldPasswd (%s),
>@@ -313,6 +293,26 @@ parse_req_done:
> 		goto free_and_return;
> 	 }
> 
>+	if (usetxn) {
>+                Slapi_DN *sdn = slapi_sdn_new_dn_byref(dn);
>+                Slapi_Backend *be = slapi_be_select(sdn);
>+                slapi_sdn_free(&sdn);
>+                if (be) {
>+			chpwop_pb = slapi_pblock_new();
>+			if (slapi_pblock_set(chpwop_pb, SLAPI_BACKEND, be)) {
>+				LOG_FATAL("slapi_pblock_set failed!\n");
>+				rc = LDAP_OPERATIONS_ERROR;
>+				goto free_and_return;
>+			}
>+			rc = slapi_back_transaction_begin(chpwop_pb);
>+			if (rc) {
>+				LOG_FATAL("failed to start transaction\n");
>+			}
>+		} else {
>+			LOG_FATAL("failed to get be backend from %s\n", dn);
>+		}
>+	}
>+
> 	 /* Now we have the DN, look for the entry */
> 	 ret = ipapwd_getEntry(dn, &targetEntry, attrlist);
> 	 /* If we can't find the entry, then that's an error */
>-- 
>1.8.1.4
>

Flags:

rcritten: review+

Actions: View | Diff

Attachments on bug 913751: 702805 | 710779