Attachment 713843 Details for Bug 907894 – Proposed patch - part 3 - schedwrk: Set values before create callback

[patch] Proposed patch - part 3 - schedwrk: Set values before create callback

2013-03-15-0001-schedwrk-Set-values-before-create-callback.patch (text/plain), 1.11 KB, created by Jan Friesse on 2013-03-21 13:28:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Friesse

Created: 2013-03-21 13:28:25 UTC

Size: 1.11 KB

patch

obsolete

>From dad3debe4f70d66f414601c998e07e825ebfcbdc Mon Sep 17 00:00:00 2001
>From: Jan Friesse <jfriesse@redhat.com>
>Date: Fri, 15 Mar 2013 12:35:36 +0100
>Subject: [PATCH] schedwrk: Set values before create callback
>
>When totem callback is called before setting value, NULL can be called,
>resulting in segfault.
>
>Signed-off-by: Jan Friesse <jfriesse@redhat.com>
>---
> exec/schedwrk.c |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/exec/schedwrk.c b/exec/schedwrk.c
>index 0591063..e7ffe92 100644
>--- a/exec/schedwrk.c
>+++ b/exec/schedwrk.c
>@@ -118,6 +118,10 @@ static int schedwrk_internal_create (
> 		goto error_destroy;
> 	}
> 
>+	instance->schedwrk_fn = schedwrk_fn;
>+	instance->context = context;
>+	instance->lock = lock;
>+
> 	totempg_callback_token_create (
> 		&instance->callback_handle,
> 		TOTEM_CALLBACK_TOKEN_SENT,
>@@ -125,10 +129,6 @@ static int schedwrk_internal_create (
> 		schedwrk_do,
> 		handle2void (*handle));
> 
>-	instance->schedwrk_fn = schedwrk_fn;
>-	instance->context = context;
>-	instance->lock = lock;
>-
>         hdb_handle_put (&schedwrk_instance_database, *handle);
> 
> 	return (0);
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 907894: 693380 | 693381 | 706733 | 713841 | 713842 | 713843 | 713844 | 713855 | 754386