Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 714660 Details for
Bug 908093
gfs2: withdraw does not wait for gfs_controld
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
RHEL6 crosswrite patch
bz908093.rhel6.patch (text/plain), 2.83 KB, created by
Robert Peterson
on 2013-03-22 17:02:57 UTC
(
hide
)
Description:
RHEL6 crosswrite patch
Filename:
MIME Type:
Creator:
Robert Peterson
Created:
2013-03-22 17:02:57 UTC
Size:
2.83 KB
patch
obsolete
>commit 7e98eceaddb4ae4771a90cecf41370a347b9e773 >Author: Bob Peterson <rpeterso@redhat.com> >Date: Fri Mar 22 09:51:24 2013 -0700 > > GFS2: Reinstate withdraw ack system > > This patch reinstates the ack system which withdraw should be using. It > appears to have been accidentally forgotten when the lock module was > merged into GFS2, due to two different sysfs files having the same name. > > rhbz#908093 > >diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h >index 8d35697..7b56b90 100644 >--- a/fs/gfs2/incore.h >+++ b/fs/gfs2/incore.h >@@ -600,6 +600,7 @@ struct gfs2_sbd { > struct gfs2_glock *sd_trans_gl; > wait_queue_head_t sd_glock_wait; > atomic_t sd_glock_disposal; >+ struct completion sd_wdack; > > /* Inode Stuff */ > >diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c >index 09213d4..1d1fffe 100644 >--- a/fs/gfs2/ops_fstype.c >+++ b/fs/gfs2/ops_fstype.c >@@ -88,6 +88,7 @@ static struct gfs2_sbd *init_sbd(struct super_block *sb) > > init_waitqueue_head(&sdp->sd_glock_wait); > atomic_set(&sdp->sd_glock_disposal, 0); >+ init_completion(&sdp->sd_wdack); > spin_lock_init(&sdp->sd_statfs_spin); > > spin_lock_init(&sdp->sd_rindex_spin); >diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c >index 81fc15a..a72ccbf 100644 >--- a/fs/gfs2/sys.c >+++ b/fs/gfs2/sys.c >@@ -332,6 +332,28 @@ static ssize_t block_store(struct gfs2_sbd *sdp, const char *buf, size_t len) > return ret; > } > >+static ssize_t wdack_show(struct gfs2_sbd *sdp, char *buf) >+{ >+ int val = completion_done(&sdp->sd_wdack) ? 1 : 0; >+ >+ return sprintf(buf, "%d\n", val); >+} >+ >+static ssize_t wdack_store(struct gfs2_sbd *sdp, const char *buf, size_t len) >+{ >+ ssize_t ret = len; >+ int val; >+ >+ val = simple_strtol(buf, NULL, 0); >+ >+ if ((val == 1) && >+ !strcmp(sdp->sd_lockstruct.ls_ops->lm_proto_name, "lock_dlm")) >+ complete(&sdp->sd_wdack); >+ else >+ ret = -EINVAL; >+ return ret; >+} >+ > static ssize_t lkfirst_show(struct gfs2_sbd *sdp, char *buf) > { > struct lm_lockstruct *ls = &sdp->sd_lockstruct; >@@ -395,7 +417,7 @@ static struct gfs2_attr gdlm_attr_##_name = __ATTR(_name,_mode,_show,_store) > > GDLM_ATTR(proto_name, 0444, proto_name_show, NULL); > GDLM_ATTR(block, 0644, block_show, block_store); >-GDLM_ATTR(withdraw, 0644, withdraw_show, withdraw_store); >+GDLM_ATTR(withdraw, 0644, wdack_show, wdack_store); > GDLM_ATTR(jid, 0444, jid_show, NULL); > GDLM_ATTR(first, 0444, lkfirst_show, NULL); > GDLM_ATTR(first_done, 0444, first_done_show, NULL); >diff --git a/fs/gfs2/util.c b/fs/gfs2/util.c >index 1530ff1..3d925b1 100644 >--- a/fs/gfs2/util.c >+++ b/fs/gfs2/util.c >@@ -55,6 +55,9 @@ int gfs2_lm_withdraw(struct gfs2_sbd *sdp, char *fmt, ...) > > kobject_uevent(&sdp->sd_kobj, KOBJ_OFFLINE); > >+ if (!strcmp(sdp->sd_lockstruct.ls_ops->lm_proto_name, "lock_dlm")) >+ wait_for_completion(&sdp->sd_wdack); >+ > if (lm->lm_unmount) { > fs_err(sdp, "telling LM to unmount\n"); > lm->lm_unmount(sdp);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 908093
:
693853
| 714660