Attachment 716473 Details for Bug 785460 – review.txt

review.txt

review.txt (text/plain), 7.27 KB, created by Remi Collet on 2013-03-26 12:06:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2013-03-26 12:06:44 UTC

Size: 7.27 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>[x] = Pass
>[!] = Fail
>[-] = Not applicable
>[?] = Not evaluated
>[ ] = Manual review needed
>
>
>Issues:
>=======
>[!]: License field in the package spec file matches the actual license.
>
>	Please correct License (with the comment) :
>
>	# lib/Horde/Mime.php is BSD and LGPLv2
>	# other files are LGPLv2
>	License: LGPLv2 and BSD
>
>[!]: Each %files section contains %defattr if rpm < 4.4
>     Note: %defattr present but not needed
>[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf %{buildroot} present but not required
>	As Buildroot is not present, both could be clean (not a blocker)
>
>[!]: Requires correct, justified where necessary.
>	A typo in the Requires list.
>		BuildRequires:  php-pear(PEAR) >= 1.7.0
>	Listed twice should be 
>		Requires:  php-pear(PEAR) >= 1.7.0
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf %{buildroot} present but not required
>[x]: Sources contain only permissible code or content.
>[!]: Each %files section contains %defattr if rpm < 4.4
>     Note: %defattr present but not needed
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package requires other packages for directories it uses.
>[x]: Package uses nothing in %doc for runtime.
>[-]: Package is not known to require ExcludeArch.
>[x]: Package complies to the Packaging Guidelines
>[!]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "BSD (3 clause)", "Unknown or generated". 2 files have unknown license.
>     Detailed output of licensecheck in /home/extras/SPECS/review/785460-php-
>     horde-Horde-Mime/licensecheck.txt
>[x]: Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[!]: Requires correct, justified where necessary.
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Large documentation must go in a -doc subpackage.
>     Note: Documentation size is 30720 bytes in 2 files.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Fully versioned dependency in subpackages, if present.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package do not use a name that already exist
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: No rpmlint messages.
>
>PHP:
>[x]: Package requires php-common instead of php.
>
>===== SHOULD items =====
>
>Generic:
>[-]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[ ]: Package functions as described.
>[ ]: Latest version is packaged.
>[ ]: Package does not include license text files separate from upstream.
>[ ]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[ ]: Package should compile and build into binary rpms on all supported
>     architectures.
>[ ]: %check is present and all tests pass.
>[ ]: Packages should try to preserve timestamps of original installed files.
>[x]: Sources can be downloaded from URI in Source: tag
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[x]: Dist tag is present.
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: SourceX tarball generation or download is documented.
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>[x]: Rpmlint is run on all installed packages.
>     Note: No rpmlint messages.
>[x]: Spec file according to URL is the same as in SRPM.
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>     Note:  Time: 1 second, Memory: 25.50Mb Required PHP 5.3.0 (min) phpci
>     static analyze results in /home/extras/SPECS/review/785460-php-horde-
>     Horde-Mime/phpci.log
>
>
>Rpmlint
>-------
>Checking: php-horde-Horde-Mime-2.0.4-1.fc19.noarch.rpm
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-horde-Horde-Mime
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-horde-Horde-Mime (rpmlib, GLIBC filtered):
>    /bin/sh
>    /usr/bin/pear
>    php-channel(pear.horde.org)
>    php-common
>    php-date
>    php-fileinfo
>    php-intl
>    php-pcre
>    php-pear(Net_DNS2)
>    php-pear(pear.horde.org/Horde_Exception)
>    php-pear(pear.horde.org/Horde_Mail)
>    php-pear(pear.horde.org/Horde_Nls)
>    php-pear(pear.horde.org/Horde_Stream_Filter)
>    php-pear(pear.horde.org/Horde_Support)
>    php-pear(pear.horde.org/Horde_Text_Filter)
>    php-pear(pear.horde.org/Horde_Text_Flowed)
>    php-pear(pear.horde.org/Horde_Translation)
>    php-pear(pear.horde.org/Horde_Util)
>    php-spl
>
>
>
>Provides
>--------
>php-horde-Horde-Mime:
>    php-horde-Horde-Mime
>    php-pear(pear.horde.org/Horde_Mime)
>
>
>
>MD5-sum check
>-------------
>http://pear.horde.org/get/Horde_Mime-2.0.4.tgz :
>  CHECKSUM(SHA256) this package     : b821e98ad90bdd3b97393cf1331f4f6016d977d3964891a315eb8a2a16f6bcea
>  CHECKSUM(SHA256) upstream package : b821e98ad90bdd3b97393cf1331f4f6016d977d3964891a315eb8a2a16f6bcea
>
>
>Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
>Buildroot used: fedora-rawhide-x86_64
>Command line :/usr/bin/fedora-review -b 785460

Actions: View

Attachments on bug 785460: 716472 | 716473