Attachment 804645 Details for Bug 982285 – review notes

review notes

review.txt (text/plain), 24.81 KB, created by gil cattaneo on 2013-09-29 09:19:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: gil cattaneo

Created: 2013-09-29 09:19:24 UTC

Size: 24.81 KB

patch

obsolete

>
>This is a review *template*. Besides handling the [ ]-marked tests you are
>also supposed to fix the template before pasting into bugzilla:
>- Add issues you find to the list of issues on top. If there isn't such
>  a list, create one.
>- Add your own remarks to the template checks.
>- Add new lines marked [!] or [?] when you discover new things not
>  listed by fedora-review.
>- Change or remove any text in the template which is plain wrong. In this
>  case you could also file a bug against fedora-review
>- Remove the "[ ] Manual check required", you will not have any such lines
>  in what you paste.
>- Remove attachments which you deem not really useful (the rpmlint
>  ones are mandatory, though)
>- Remove this text
>
>
>
>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>
>Issues:
>=======
>- Packages have proper BuildRequires/Requires on jpackage-utils
>- Permissions on files are set properly.
>  Note: See rpmlint output
>  See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
>- All build dependencies are listed in BuildRequires, except for any that are
>  listed in the exceptions section of Packaging Guidelines.
>  Note: These BR are not needed: gcc-c++
>  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
>
>
>===== MUST items =====
>
>C/C++:
>[x]: Package does not contain kernel modules.
>[x]: Package contains no static executables.
>[x]: Development (unversioned) .so files in -devel subpackage, if present.
>     Note: Unversioned so-files in private %_libdir subdirectory (see
>     attachment). Verify they are not in ld path.
>[x]: Header files in -devel subpackage, if present.
>[x]: ldconfig called in %post and %postun if required.
>[x]: Package does not contain any libtool archives (.la)
>[x]: Rpath absent or only used for internal libs.
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[!]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "Apache (v2.0)", "BSD (2 clause)", "*No copyright* Apache (v2.0)",
>     "Unknown or generated", "zlib/libpng". 55 files have unknown license.
>     Detailed output of licensecheck in
>     /home/gil/982285-thrift/licensecheck.txt
>[!]: License file installed when any subpackage combination is installed.
>[x]: %build honors applicable compiler flags or justifies otherwise.
>[x]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[x]: Sources contain only permissible code or content.
>[-]: Package contains desktop file if it is a GUI application.
>[x]: Development files must be in a -devel package
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[x]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Requires correct, justified where necessary.
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Useful -debuginfo package or justification otherwise.
>[x]: Package is not known to require an ExcludeArch tag.
>[x]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 122880 bytes in 12 files.
>[x]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: Package requires other packages for directories it uses.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Each %files section contains %defattr if rpm < 4.4
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Package does not contain duplicates in %files.
>[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package do not use a name that already exist
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>Java:
>[x]: Javadoc documentation files are generated and included in -javadoc
>     subpackage
>[x]: Javadoc subpackages should not have Requires: jpackage-utils
>[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
>[x]: Bundled jar/class files should be removed before build
>
>Maven:
>[x]: Pom files have correct Maven mapping
>     Note: Some add_maven_depmap calls found. Please check if they are correct
>     or update to latest guidelines
>[x]: If package contains pom.xml files install it (including depmaps) even
>     when building with ant
>[x]: Old add_to_maven_depmap macro is not being used
>[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
>     utils for %update_maven_depmap macro
>[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
>[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
>
>Perl:
>[x]: Package contains the mandatory BuildRequires and Requires:.
>     Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
>     $version)) missing?
>
>Python:
>[x]: Python eggs must not download any dependencies during the build process.
>[x]: A package which is used by another package via an egg interface should
>     provide egg info.
>[x]: Package meets the Packaging Guidelines::Python
>[x]: Package contains BR: python2-devel or python3-devel
>[x]: Binary eggs must be removed in %prep
>
>===== SHOULD items =====
>
>Generic:
>[!]: Sources can be downloaded from URI in Source: tag
>     Note: Could not download Source0
>     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
>[!]: Uses parallel make %{?_smp_mflags} macro.
>[x]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[x]: Fully versioned dependency in subpackages if applicable.
>     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in perl-thrift
>     , java-libthrift-javadoc , java-libthrift
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
>[x]: Scriptlets must be sane, if used.
>[x]: SourceX tarball generation or download is documented.
>     Note: Package contains tarball without URL, check comments
>[x]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[x]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[x]: Dist tag is present (not strictly required in GL).
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: The placement of pkgconfig(.pc) files are correct.
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>Java:
>[x]: Packages are noarch unless they use JNI
>     Note: thrift subpackage is not noarch. Please verify manually
>[x]: Package uses upstream build method (ant/maven/etc.)
>
>===== EXTRA items =====
>
>Generic:
>[!]: Package should not use obsolete m4 macros
>     Note: Some obsoleted macros found, see the attachment.
>     See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>[x]: Spec file according to URL is the same as in SRPM.
>
>
>Rpmlint
>-------
>Checking: thrift-0.9.1-2.fc21.i686.rpm
>          thrift-devel-0.9.1-2.fc21.i686.rpm
>          python-thrift-0.9.1-2.fc21.i686.rpm
>          perl-thrift-0.9.1-2.fc21.noarch.rpm
>          java-libthrift-javadoc-0.9.1-2.fc21.noarch.rpm
>          java-libthrift-0.9.1-2.fc21.noarch.rpm
>          erlang-thrift-0.9.1-2.fc21.i686.rpm
>          thrift-0.9.1-2.fc21.src.rpm
>thrift.i686: W: no-manual-page-for-binary thrift
>python-thrift.i686: E: non-standard-executable-perm /usr/lib/python2.7/site-packages/thrift/protocol/fastbinary.so 0775L
>erlang-thrift.i686: W: only-non-binary-in-usr-lib
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_reconnecting_client.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/include/thrift_protocol_behaviour.hrl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_file_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_memory_buffer.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_base64_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_buffered_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_disk_log_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/include/thrift_protocol.hrl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_transport_state_test.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_socket_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_service.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_client.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_protocol.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_processor.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_socket_server.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_server.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_http_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_client_util.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/include/thrift_transport_behaviour.hrl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/include/thrift_constants.hrl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/ebin/thrift.app
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_json_protocol.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_framed_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_binary_protocol.erl
>thrift.src: W: strange-permission thrift-0.9.1-bootstrap.sh 0755L
>thrift.src:67: W: macro-in-comment %{name}
>thrift.src:67: W: macro-in-comment %{version}
>thrift.src:67: W: macro-in-comment %{name}
>thrift.src:67: W: macro-in-comment %{version}
>thrift.src:292: W: macro-in-comment %{buildroot}
>thrift.src:295: W: macro-in-comment %{python_sitearch}
>thrift.src:295: W: macro-in-comment %{python_sitelib}
>thrift.src:297: W: macro-in-comment %{buildroot}
>thrift.src:297: W: macro-in-comment %{python_sitearch}
>thrift.src:297: W: macro-in-comment %{name}
>thrift.src:298: W: macro-in-comment %{buildroot}
>thrift.src:298: W: macro-in-comment %{python_sitelib}
>thrift.src:298: W: macro-in-comment %{name}
>thrift.src:298: W: macro-in-comment %{buildroot}
>thrift.src:298: W: macro-in-comment %{python_sitearch}
>thrift.src:299: W: macro-in-comment %{buildroot}
>thrift.src:299: W: macro-in-comment %{python_sitelib}
>thrift.src:304: W: macro-in-comment %{buildroot}
>thrift.src:77: W: mixed-use-of-spaces-and-tabs (spaces: line 77, tab: line 60)
>thrift.src: W: patch-not-applied Patch2: thrift-0.9.1-distbuild-issues.patch
>thrift.src: W: invalid-url Source0: http://archive.apache.org/dist/thrift/0.9.1/thrift-0.9.1-ff980c1.tar.gz HTTP Error 404: Not Found
>8 packages and 0 specfiles checked; 26 errors, 24 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint thrift-devel perl-thrift java-libthrift erlang-thrift java-libthrift-javadoc python-thrift thrift
>thrift-devel.i686: W: undefined-non-weak-symbol /usr/lib/libthriftz-0.9.1.so apache::thrift::GlobalOutput
>thrift-devel.i686: W: unused-direct-shlib-dependency /usr/lib/libthriftz-0.9.1.so /lib/libssl.so.10
>thrift-devel.i686: W: unused-direct-shlib-dependency /usr/lib/libthriftz-0.9.1.so /lib/libcrypto.so.10
>thrift-devel.i686: W: unused-direct-shlib-dependency /usr/lib/libthriftz-0.9.1.so /lib/librt.so.1
>thrift-devel.i686: W: unused-direct-shlib-dependency /usr/lib/libthriftz-0.9.1.so /lib/libm.so.6
>thrift-devel.i686: W: unused-direct-shlib-dependency /usr/lib/libthrift-0.9.1.so /lib/librt.so.1
>thrift-devel.i686: W: unused-direct-shlib-dependency /usr/lib/libthrift-0.9.1.so /lib/libm.so.6
>erlang-thrift.i686: W: only-non-binary-in-usr-lib
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_reconnecting_client.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/include/thrift_protocol_behaviour.hrl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_file_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_memory_buffer.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_base64_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_buffered_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_disk_log_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/include/thrift_protocol.hrl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_transport_state_test.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_socket_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_service.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_client.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_protocol.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_processor.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_socket_server.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_server.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_http_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_client_util.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/include/thrift_transport_behaviour.hrl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/include/thrift_constants.hrl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/ebin/thrift.app
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_json_protocol.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_framed_transport.erl
>erlang-thrift.i686: E: script-without-shebang /usr/lib/erlang/lib/thrift-0.9.1/src/thrift_binary_protocol.erl
>python-thrift.i686: E: non-standard-executable-perm /usr/lib/python2.7/site-packages/thrift/protocol/fastbinary.so 0775L
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_param_spec_object
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_free
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_param_spec_string
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_intern_static_string
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_byte_array_new
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_value_get_string
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_strdup
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_value_get_uint
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_object_class_install_property
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_param_spec_uint
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_malloc0_n
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_object_new
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_value_set_string
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_type_check_class_cast
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_byte_array_free
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_return_if_fail_warning
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_set_error
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_value_get_object
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_quark_from_static_string
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_type_check_instance_is_a
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_list_append
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_type_name
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_type_check_instance_cast
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_type_register_static_simple
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_byte_array_append
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_byte_array_remove_range
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_value_set_object
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_once_init_enter
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_value_set_uint
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_malloc_n
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_once_init_leave
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_type_class_peek_parent
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_log
>thrift.i686: W: undefined-non-weak-symbol /usr/lib/libthrift_c_glib.so.0.0.0 g_type_class_adjust_private_offset
>thrift.i686: W: unused-direct-shlib-dependency /usr/lib/libthrift_c_glib.so.0.0.0 /lib/libssl.so.10
>thrift.i686: W: unused-direct-shlib-dependency /usr/lib/libthrift_c_glib.so.0.0.0 /lib/libcrypto.so.10
>thrift.i686: W: unused-direct-shlib-dependency /usr/lib/libthrift_c_glib.so.0.0.0 /lib/librt.so.1
>thrift.i686: W: no-manual-page-for-binary thrift
>7 packages and 0 specfiles checked; 26 errors, 46 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>thrift-devel (rpmlib, GLIBC filtered):
>    /usr/bin/pkg-config
>    libc.so.6
>    libcrypto.so.10
>    libcrypto.so.10(libcrypto.so.10)
>    libgcc_s.so.1
>    libgcc_s.so.1(GCC_3.0)
>    libgcc_s.so.1(GCC_4.0.0)
>    libm.so.6
>    libpthread.so.0
>    librt.so.1
>    libssl.so.10
>    libssl.so.10(libssl.so.10)
>    libstdc++.so.6
>    libstdc++.so.6(CXXABI_1.3)
>    libstdc++.so.6(CXXABI_1.3.1)
>    libthrift_c_glib.so.0
>    pkgconfig
>    pkgconfig(glib-2.0)
>    pkgconfig(gobject-2.0)
>    pkgconfig(thrift)
>    rtld(GNU_HASH)
>    thrift(x86-32)
>
>perl-thrift (rpmlib, GLIBC filtered):
>    perl
>    perl(:MODULE_COMPAT_5.18.1)
>    perl(Bit::Vector)
>    perl(Encode)
>    perl(HTTP::Request)
>    perl(IO::Select)
>    perl(IO::Socket::INET)
>    perl(IO::String)
>    perl(LWP::UserAgent)
>    perl(POSIX)
>    perl(Thrift)
>    perl(Thrift::BinaryProtocol)
>    perl(Thrift::BufferedTransport)
>    perl(Thrift::Protocol)
>    perl(Thrift::Server)
>    perl(Thrift::ServerTransport)
>    perl(Thrift::Socket)
>    perl(Thrift::Transport)
>    perl(base)
>    perl(constant)
>    perl(strict)
>    perl(utf8)
>    perl(warnings)
>
>java-libthrift (rpmlib, GLIBC filtered):
>    java
>    jpackage-utils
>    mvn(commons-lang:commons-lang)
>    mvn(org.apache.httpcomponents:httpclient)
>    mvn(org.apache.httpcomponents:httpcore)
>    mvn(org.slf4j:slf4j-api)
>
>erlang-thrift (rpmlib, GLIBC filtered):
>    erlang
>    erlang-jsx
>    thrift(x86-32)
>
>java-libthrift-javadoc (rpmlib, GLIBC filtered):
>    java-libthrift
>    jpackage-utils
>
>python-thrift (rpmlib, GLIBC filtered):
>    libc.so.6
>    libpthread.so.0
>    libpython2.7.so.1.0
>    python(abi)
>    python2
>    rtld(GNU_HASH)
>    thrift(x86-32)
>
>thrift (rpmlib, GLIBC filtered):
>    /sbin/ldconfig
>    bison
>    boost
>    flex
>    libc.so.6
>    libcrypto.so.10
>    libgcc_s.so.1
>    libgcc_s.so.1(GCC_3.0)
>    libm.so.6
>    libpthread.so.0
>    librt.so.1
>    libssl.so.10
>    libstdc++.so.6
>    libstdc++.so.6(CXXABI_1.3)
>    libstdc++.so.6(CXXABI_1.3.1)
>    mono-core
>    openssl
>    rtld(GNU_HASH)
>
>
>
>Provides
>--------
>thrift-devel:
>    libthrift-0.9.1.so
>    libthriftz-0.9.1.so
>    pkgconfig(thrift)
>    pkgconfig(thrift-z)
>    pkgconfig(thrift_c_glib)
>    thrift-devel
>    thrift-devel(x86-32)
>
>perl-thrift:
>    perl(TApplicationException)
>    perl(TMessageType)
>    perl(TProtocolException)
>    perl(TProtocolFactory)
>    perl(TTransportException)
>    perl(TType)
>    perl(Thrift)
>    perl(Thrift::BinaryProtocol)
>    perl(Thrift::BinaryProtocolFactory)
>    perl(Thrift::BufferedTransport)
>    perl(Thrift::BufferedTransportFactory)
>    perl(Thrift::ForkingServer)
>    perl(Thrift::FramedTransport)
>    perl(Thrift::HttpClient)
>    perl(Thrift::MemoryBuffer)
>    perl(Thrift::Protocol)
>    perl(Thrift::Server)
>    perl(Thrift::ServerSocket)
>    perl(Thrift::ServerTransport)
>    perl(Thrift::SimpleServer)
>    perl(Thrift::Socket)
>    perl(Thrift::TException)
>    perl(Thrift::Transport)
>    perl(Thrift::TransportFactory)
>    perl-thrift
>
>java-libthrift:
>    java-libthrift
>    mvn(org.apache.thrift:libthrift)
>    osgi(org.apache.thrift)
>
>erlang-thrift:
>    erlang-thrift
>    erlang-thrift(x86-32)
>
>java-libthrift-javadoc:
>    java-libthrift-javadoc
>
>python-thrift:
>    python-thrift
>    python-thrift(x86-32)
>
>thrift:
>    libthrift_c_glib.so.0
>    thrift
>    thrift(x86-32)
>
>
>
>Unversioned so-files
>--------------------
>python-thrift: /usr/lib/python2.7/site-packages/thrift/protocol/fastbinary.so
>
>AutoTools: Obsoleted m4s found
>------------------------------
>  AC_PROG_LIBTOOL found in: thrift-0.9.1/configure.ac:89
>
>
>Source checksums
>----------------
>http://repo1.maven.org/maven2/org/apache/thrift/libthrift/0.9.1/libthrift-0.9.1.pom :
>  CHECKSUM(SHA256) this package     : 502beb3f689f0e4b96dbacf6d97f70506b218da4c634a82d04159e34172849c7
>  CHECKSUM(SHA256) upstream package : 502beb3f689f0e4b96dbacf6d97f70506b218da4c634a82d04159e34172849c7
>
>
>Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
>Command line :/usr/bin/fedora-review -b 982285 -m fedora-rawhide-i386
>Buildroot used: fedora-rawhide-i386
>Active plugins: Java, C/C++, Python, Shell-api, Perl, Generic
>Disabled plugins: Ruby, R, SugarActivity, PHP
>Disabled flags: EPEL5, EXARCH, DISTTAG

Actions: View

Attachments on bug 982285: 804645 | 804646 | 806704 | 806880 | 806998 | 811763