Login
Log in using an SSO provider:
Fedora Account System
Red Hat Associate
Red Hat Customer
Login using a Red Hat Bugzilla account
Forgot Password
Create an Account
Red Hat Bugzilla – Attachment 811763 Details for
Bug 982285
Review Request: thrift - software framework for scalable cross-language services development
Home
New
Search
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh92 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
[?]
This site requires JavaScript to be enabled to function correctly, please enable it.
review notes
review.txt (text/plain), 15.38 KB, created by
gil cattaneo
on 2013-10-13 15:45:11 UTC
(
hide
)
Description:
review notes
Filename:
MIME Type:
Creator:
gil cattaneo
Created:
2013-10-13 15:45:11 UTC
Size:
15.38 KB
patch
obsolete
>Package Review >============== > >Legend: >[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated >[ ] = Manual review needed > > >Issues: >======= >- Packages have proper BuildRequires/Requires on jpackage-utils > > >===== MUST items ===== > >C/C++: >[x]: Package does not contain kernel modules. >[x]: Package contains no static executables. >[x]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. >[x]: Header files in -devel subpackage, if present. >[x]: ldconfig called in %post and %postun if required. >[x]: Package does not contain any libtool archives (.la) >[x]: Rpath absent or only used for internal libs. > >Generic: >[x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. >[x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "Apache (v2.0)", "BSD (2 clause)", "*No copyright* Apache (v2.0)", > "Unknown or generated", "zlib/libpng". 55 files have unknown license. > Detailed output of licensecheck in > /home/gil/982285-thrift/licensecheck.txt >[x]: License file installed when any subpackage combination is installed. >[x]: If the package is under multiple licenses, the licensing breakdown must > be documented in the spec. >[x]: %build honors applicable compiler flags or justifies otherwise. >[x]: Package contains no bundled libraries without FPC exception. >[x]: Changelog in prescribed format. >[x]: Sources contain only permissible code or content. >[-]: Package contains desktop file if it is a GUI application. >[x]: Development files must be in a -devel package >[x]: Package uses nothing in %doc for runtime. >[x]: Package consistently uses macros (instead of hard-coded directory names). >[x]: Package is named according to the Package Naming Guidelines. >[x]: Package does not generate any conflict. >[x]: Package obeys FHS, except libexecdir and /usr/target. >[-]: If the package is a rename of another package, proper Obsoletes and > Provides are present. >[x]: Requires correct, justified where necessary. >[x]: Spec file is legible and written in American English. >[-]: Package contains systemd file(s) if in need. >[x]: Useful -debuginfo package or justification otherwise. >[x]: Package is not known to require an ExcludeArch tag. >[-]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 204800 bytes in 20 files. >[x]: Package complies to the Packaging Guidelines >[x]: Package successfully compiles and builds into binary rpms on at least one > supported primary architecture. >[x]: Package installs properly. >[x]: Rpmlint is run on all rpms the build produces. > Note: There are rpmlint messages (see attachment). >[x]: If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %doc. >[x]: Package requires other packages for directories it uses. >[x]: Package must own all directories that it creates. >[x]: Package does not own files or directories owned by other packages. >[x]: All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. >[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT >[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. >[x]: Each %files section contains %defattr if rpm < 4.4 >[x]: Macros in Summary, %description expandable at SRPM build time. >[x]: Package does not contain duplicates in %files. >[x]: Permissions on files are set properly. >[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't > work. >[x]: Package is named using only allowed ASCII characters. >[x]: Package do not use a name that already exist >[x]: Package is not relocatable. >[x]: Sources used to build the package match the upstream source, as provided > in the spec URL. >[x]: Spec file name must match the spec package %{name}, in the format > %{name}.spec. >[x]: File names are valid UTF-8. >[x]: Packages must not store files under /srv, /opt or /usr/local > >Java: >[x]: Javadoc documentation files are generated and included in -javadoc > subpackage >[x]: Javadoc subpackages should not have Requires: jpackage-utils >[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) >[x]: Bundled jar/class files should be removed before build > >Maven: >[x]: Pom files have correct Maven mapping > Note: Some add_maven_depmap calls found. Please check if they are correct > or update to latest guidelines >[x]: If package contains pom.xml files install it (including depmaps) even > when building with ant >[x]: Old add_to_maven_depmap macro is not being used >[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- > utils for %update_maven_depmap macro >[x]: Package DOES NOT use %update_maven_depmap in %post/%postun >[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms > >Perl: >[x]: Package contains the mandatory BuildRequires and Requires:. > Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo > $version)) missing? > >Python: >[x]: Python eggs must not download any dependencies during the build process. >[x]: A package which is used by another package via an egg interface should > provide egg info. >[x]: Package meets the Packaging Guidelines::Python >[x]: Package contains BR: python2-devel or python3-devel >[x]: Binary eggs must be removed in %prep > >===== SHOULD items ===== > >Generic: >[x]: If the source package does not include license text(s) as a separate file > from upstream, the packager SHOULD query upstream to include it. >[x]: Final provides and requires are sane (see attachments). >[x]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in perl-thrift > , libthrift-javadoc , libthrift-java , fb303-devel , python-fb303 , > fb303-java >[x]: Package functions as described. >[x]: Latest version is packaged. >[x]: Package does not include license text files separate from upstream. >[x]: Patches link to upstream bugs/comments/lists or are otherwise justified. >[x]: Scriptlets must be sane, if used. >[x]: Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. >[x]: Package should compile and build into binary rpms on all supported > architectures. >[x]: %check is present and all tests pass. >[x]: Packages should try to preserve timestamps of original installed files. >[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file >[x]: Sources can be downloaded from URI in Source: tag >[x]: Reviewer should test that the package builds in mock. >[x]: Buildroot is not present >[x]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) >[x]: Dist tag is present (not strictly required in GL). >[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. >[x]: Uses parallel make %{?_smp_mflags} macro. >[x]: The placement of pkgconfig(.pc) files are correct. >[x]: SourceX tarball generation or download is documented. >[x]: SourceX is a working URL. >[x]: Spec use %global instead of %define unless justified. > >Java: >[x]: Packages are noarch unless they use JNI > Note: thrift subpackage is not noarch. Please verify manually >[x]: Package uses upstream build method (ant/maven/etc.) > >===== EXTRA items ===== > >Generic: >[x]: Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). >[x]: Large data in /usr/share should live in a noarch subpackage if package is > arched. >[x]: Package should not use obsolete m4 macros >[x]: Spec file according to URL is the same as in SRPM. > > >Rpmlint >------- >Checking: thrift-0.9.1-6.fc21.i686.rpm > thrift-devel-0.9.1-6.fc21.i686.rpm > python-thrift-0.9.1-6.fc21.i686.rpm > perl-thrift-0.9.1-6.fc21.noarch.rpm > libthrift-javadoc-0.9.1-6.fc21.noarch.rpm > libthrift-java-0.9.1-6.fc21.noarch.rpm > erlang-thrift-0.9.1-6.fc21.i686.rpm > fb303-0.9.1-6.fc21.i686.rpm > fb303-devel-0.9.1-6.fc21.i686.rpm > python-fb303-0.9.1-6.fc21.i686.rpm > fb303-java-0.9.1-6.fc21.noarch.rpm > thrift-0.9.1-6.fc21.src.rpm >erlang-thrift.i686: W: only-non-binary-in-usr-lib >fb303.i686: W: spelling-error %description -l en_US uptime -> up time, up-time, suppertime >fb303-devel.i686: W: no-soname /usr/lib/libfb303.so >thrift.src:373: W: rpm-buildroot-usage %build mkdir -p %{buildroot}%{_javadir} >thrift.src:374: W: rpm-buildroot-usage %build /usr/bin/install -c -m 644 build/libfb303.jar %{buildroot}%{_javadir} >thrift.src: W: patch-fuzz-is-changed >thrift.src:88: W: mixed-use-of-spaces-and-tabs (spaces: line 88, tab: line 61) >12 packages and 0 specfiles checked; 0 errors, 7 warnings. > > > > >Rpmlint (installed packages) >---------------------------- ># rpmlint thrift-devel fb303-devel perl-thrift erlang-thrift python-fb303 libthrift-javadoc libthrift-java python-t >hrift fb303 fb303-java thrift >fb303-devel.i686: W: no-soname /usr/lib/libfb303.so >erlang-thrift.i686: W: only-non-binary-in-usr-lib >fb303.i686: W: spelling-error %description -l en_US uptime -> up time, up-time, suppertime >11 packages and 0 specfiles checked; 0 errors, 3 warnings. ># echo 'rpmlint-done:' > > > >Requires >-------- >thrift-devel (rpmlib, GLIBC filtered): > /usr/bin/pkg-config > libQtCore.so.4 > libQtNetwork.so.4 > libc.so.6 > libcrypto.so.10 > libcrypto.so.10(libcrypto.so.10) > libgcc_s.so.1 > libgcc_s.so.1(GCC_3.0) > libgcc_s.so.1(GCC_4.0.0) > libpthread.so.0 > libssl.so.10 > libssl.so.10(libssl.so.10) > libstdc++.so.6 > libstdc++.so.6(CXXABI_1.3) > libstdc++.so.6(CXXABI_1.3.1) > libthrift-0.9.1.so > libthrift_c_glib.so.0 > libz.so.1 > pkgconfig > pkgconfig(glib-2.0) > pkgconfig(gobject-2.0) > pkgconfig(thrift) > rtld(GNU_HASH) > thrift(x86-32) > >fb303-devel (rpmlib, GLIBC filtered): > fb303(x86-32) > libc.so.6 > libgcc_s.so.1 > libgcc_s.so.1(GCC_3.0) > libstdc++.so.6 > libstdc++.so.6(CXXABI_1.3) > libthrift-0.9.1.so > rtld(GNU_HASH) > >perl-thrift (rpmlib, GLIBC filtered): > perl > perl(:MODULE_COMPAT_5.18.1) > perl(Bit::Vector) > perl(Encode) > perl(HTTP::Request) > perl(IO::Select) > perl(IO::Socket::INET) > perl(IO::String) > perl(LWP::UserAgent) > perl(POSIX) > perl(Thrift) > perl(Thrift::BinaryProtocol) > perl(Thrift::BufferedTransport) > perl(Thrift::Protocol) > perl(Thrift::Server) > perl(Thrift::ServerTransport) > perl(Thrift::Socket) > perl(Thrift::Transport) > perl(base) > perl(constant) > perl(strict) > perl(utf8) > perl(warnings) > >erlang-thrift (rpmlib, GLIBC filtered): > erlang > erlang-jsx > thrift(x86-32) > >python-fb303 (rpmlib, GLIBC filtered): > /usr/bin/env > fb303(x86-32) > python(abi) > >libthrift-javadoc (rpmlib, GLIBC filtered): > jpackage-utils > libthrift-java > >libthrift-java (rpmlib, GLIBC filtered): > java > jpackage-utils > mvn(commons-lang:commons-lang) > mvn(org.apache.httpcomponents:httpclient) > mvn(org.apache.httpcomponents:httpcore) > mvn(org.slf4j:slf4j-api) > >python-thrift (rpmlib, GLIBC filtered): > libc.so.6 > libpthread.so.0 > libpython2.7.so.1.0 > python(abi) > python2 > rtld(GNU_HASH) > thrift(x86-32) > >fb303 (rpmlib, GLIBC filtered): > thrift(x86-32) > >fb303-java (rpmlib, GLIBC filtered): > java > jpackage-utils > mvn(commons-lang:commons-lang) > mvn(org.apache.httpcomponents:httpclient) > mvn(org.apache.httpcomponents:httpcore) > mvn(org.slf4j:slf4j-api) > >thrift (rpmlib, GLIBC filtered): > /sbin/ldconfig > bison > boost > flex > libc.so.6 > libgcc_s.so.1 > libgcc_s.so.1(GCC_3.0) > libglib-2.0.so.0 > libgobject-2.0.so.0 > libm.so.6 > libpthread.so.0 > libstdc++.so.6 > libstdc++.so.6(CXXABI_1.3) > libstdc++.so.6(CXXABI_1.3.1) > mono-core > openssl > qt4 > rtld(GNU_HASH) > > > >Provides >-------- >thrift-devel: > libthrift-0.9.1.so > libthriftqt-0.9.1.so > libthriftz-0.9.1.so > pkgconfig(thrift) > pkgconfig(thrift-qt) > pkgconfig(thrift-z) > pkgconfig(thrift_c_glib) > thrift-devel > thrift-devel(x86-32) > >fb303-devel: > fb303-devel > fb303-devel(x86-32) > libfb303.so > >perl-thrift: > perl(TApplicationException) > perl(TMessageType) > perl(TProtocolException) > perl(TProtocolFactory) > perl(TTransportException) > perl(TType) > perl(Thrift) > perl(Thrift::BinaryProtocol) > perl(Thrift::BinaryProtocolFactory) > perl(Thrift::BufferedTransport) > perl(Thrift::BufferedTransportFactory) > perl(Thrift::ForkingServer) > perl(Thrift::FramedTransport) > perl(Thrift::HttpClient) > perl(Thrift::MemoryBuffer) > perl(Thrift::Protocol) > perl(Thrift::Server) > perl(Thrift::ServerSocket) > perl(Thrift::ServerTransport) > perl(Thrift::SimpleServer) > perl(Thrift::Socket) > perl(Thrift::TException) > perl(Thrift::Transport) > perl(Thrift::TransportFactory) > perl-thrift > >erlang-thrift: > erlang-thrift > erlang-thrift(x86-32) > >python-fb303: > python-fb303 > python-fb303(x86-32) > >libthrift-javadoc: > libthrift-javadoc > >libthrift-java: > libthrift-java > mvn(org.apache.thrift:libthrift) > osgi(org.apache.thrift) > >python-thrift: > python-thrift > python-thrift(x86-32) > >fb303: > fb303 > fb303(x86-32) > >fb303-java: > fb303-java > mvn(org.apache.thrift:libfb303) > >thrift: > libthrift_c_glib.so.0 > thrift > thrift(x86-32) > > > >Unversioned so-files >-------------------- >python-thrift: /usr/lib/python2.7/site-packages/thrift/protocol/fastbinary.so > >Source checksums >---------------- >https://raw.github.com/apache/thrift/0.9.1/bootstrap.sh : > CHECKSUM(SHA256) this package : 0281b145fb2f509f509b8677c11da98af19e28e78103a76267553ba1d0b746c1 > CHECKSUM(SHA256) upstream package : 0281b145fb2f509f509b8677c11da98af19e28e78103a76267553ba1d0b746c1 >https://gitorious.org/pkg-scribe/thrift-deb-pkg/raw/master:debian/manpage.1.ex : > CHECKSUM(SHA256) this package : a554f321ec9e86a44bb376e3d0e95a1b6631d7206c921d41f696b57d79db4be8 > CHECKSUM(SHA256) upstream package : a554f321ec9e86a44bb376e3d0e95a1b6631d7206c921d41f696b57d79db4be8 >https://github.com/apache/thrift/archive/0.9.1.tar.gz : > CHECKSUM(SHA256) this package : f9c04bf08e09de9f79dc8b0960817588ae2c08007b1980029ef1a1d8294e835f > CHECKSUM(SHA256) upstream package : f9c04bf08e09de9f79dc8b0960817588ae2c08007b1980029ef1a1d8294e835f >http://repo1.maven.org/maven2/org/apache/thrift/libthrift/0.9.1/libthrift-0.9.1.pom : > CHECKSUM(SHA256) this package : 502beb3f689f0e4b96dbacf6d97f70506b218da4c634a82d04159e34172849c7 > CHECKSUM(SHA256) upstream package : 502beb3f689f0e4b96dbacf6d97f70506b218da4c634a82d04159e34172849c7 >http://repo1.maven.org/maven2/org/apache/thrift/libfb303/0.9.1/libfb303-0.9.1.pom : > CHECKSUM(SHA256) this package : 3ff01d4d4cf6c49f07b92aea1a6b2f7e214f0a74f36a699ec4c1fec1537d71b3 > CHECKSUM(SHA256) upstream package : 3ff01d4d4cf6c49f07b92aea1a6b2f7e214f0a74f36a699ec4c1fec1537d71b3 > > >Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 >Command line :/usr/bin/fedora-review -b 982285 -m fedora-rawhide-i386 >Buildroot used: fedora-rawhide-i386 >Active plugins: Java, C/C++, Python, Shell-api, Perl, Generic >Disabled plugins: Ruby, R, SugarActivity, PHP >Disabled flags: EPEL5, EXARCH, DISTTAG
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 982285
:
804645
|
804646
|
806704
|
806880
|
806998
| 811763