Attachment 826469 Details for Bug 1032447 – skip empty slot

skip empty slot

skip-empty-slot.patch (text/plain), 1.02 KB, created by IBM Bug Proxy on 2013-11-20 08:53:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: IBM Bug Proxy

Created: 2013-11-20 08:53:27 UTC

Size: 1.02 KB

patch

obsolete

>diff -Naurp a/lib/sysfs.c b/lib/sysfs.c
>--- a/lib/sysfs.c	2012-05-28 09:16:50.000000000 -0400
>+++ b/lib/sysfs.c	2013-10-18 06:01:18.116755882 -0400
>@@ -212,6 +212,7 @@ sysfs_fill_slots(struct pci_access *a)
>       FILE *file;
>       unsigned int dom, bus, dev;
>       struct pci_dev *d;
>+      int res = 0;
> 
>       /* ".", ".." or a special non-device perhaps */
>       if (entry->d_name[0] == '.')
>@@ -229,8 +230,14 @@ sysfs_fill_slots(struct pci_access *a)
>       if (!file)
> 	continue;
> 
>-      if (!fgets(buf, sizeof(buf), file) || sscanf(buf, "%x:%x:%x", &dom, &bus, &dev) < 3)
>-	a->warning("sysfs_fill_slots: Couldn't parse entry address %s", buf);
>+      if (!fgets(buf, sizeof(buf), file) || (res = sscanf(buf, "%x:%x:%x", &dom, &bus, &dev)) < 3){
>+      /*
>+       * If the slot is empty, its "address" entry will only
>+       * give "XXXX:XX" output,so we skip it
>+       */
>+	  if (res != 2)
>+		a->warning("sysfs_fill_slots: Couldn't parse entry address %s", buf);
>+        }
>       else
> 	{
> 	  for (d = a->devices; d; d = d->next)

Actions: View

Attachments on bug 1032447: 826469