Attachment 827180 Details for Bug 864198 – address potential security problem in grubby findtTemplate()

[patch] address potential security problem in grubby findtTemplate()

0001-findTemplate-fix-saved_entry-and-limit-general-scan.patch (text/plain), 1.15 KB, created by Gene Czarcinski on 2013-11-21 13:23:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Gene Czarcinski

Created: 2013-11-21 13:23:30 UTC

Size: 1.15 KB

patch

obsolete

>From 839c8f7930b9b44b15ddaa7144641be97e2fb790 Mon Sep 17 00:00:00 2001
>From: Gene Czarcinski <gene@czarc.net>
>Date: Tue, 19 Nov 2013 11:38:54 -0500
>Subject: [PATCH 1/2] findTemplate fix saved_entry and limit general scan
>Content-Type: text/plain; charset="utf-8"
>Content-Transfer-Encoding: 8bit
>
>---
> grubby.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/grubby.c b/grubby.c
>index bbca9d0..02ab198 100644
>--- a/grubby.c
>+++ b/grubby.c
>@@ -2086,8 +2086,13 @@ struct singleEntry * findTemplate(struct grubConfig * cfg, const char * prefix,
> 		} else {
> 		    entry = findEntryByTitle(cfg, defTitle, &index);
> 		}
>-		if (entry)
>+		if (entry) {
> 		    cfg->defaultImage = index;
>+	            if (suitableImage(entry, prefix, skipRemoved, flags)) {
>+	                fprintf(stderr,"suitable template found based on saved_entry");
>+	                return entry;
>+	            }
>+		}
> 	    }
> 	}
>     } else if (cfg->defaultImage > -1) {
>@@ -2111,6 +2116,9 @@ struct singleEntry * findTemplate(struct grubConfig * cfg, const char * prefix,
> 	    return entry;
> 	}
> 
>+        if (index >= 1)
>+            break;
>+
> 	index++;
>     }
> 
>-- 
>1.8.4.2
>

Actions: View | Diff

Attachments on bug 864198: 632180 | 632183 | 632845 | 827180 | 827181 | 827953 | 1013654