Attachment 828142 Details for Bug 903136 – 0001-ACPI-video-Add-systems-that-should-favor-native-back.patch

[patch] 0001-ACPI-video-Add-systems-that-should-favor-native-back.patch

0001-ACPI-video-Add-systems-that-should-favor-native-back.patch (text/plain), 4.71 KB, created by Igor Gnatenko on 2013-11-23 19:09:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Igor Gnatenko

Created: 2013-11-23 19:09:02 UTC

Size: 4.71 KB

patch

obsolete

>From 5b2cb3c0fdda99788ca080a99eac94662dfd43b6 Mon Sep 17 00:00:00 2001
>From: Aaron Lu <aaron.lu@intel.com>
>Date: Thu, 21 Nov 2013 13:29:09 +0800
>Subject: [PATCH] ACPI / video: Add systems that should favor native backlight
> interface
>
>On 11/21/2013 04:56 AM, Igor Gnatenko wrote:
>> Any news here? If no - I think we need re-send patch as new..
>
>Since the v2 patch can't apply cleanly on top of pm's -next tree, I
>think it's worth a re-send, so here it comes.
>---
> drivers/acpi/blacklist.c    |  8 ------
> drivers/acpi/video.c        | 65 +++++++++++++++++++++++++++++++++++++++++----
> drivers/acpi/video_detect.c |  8 ------
> 3 files changed, 60 insertions(+), 21 deletions(-)
>
>diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
>index 078c4f7..2b6a76b 100644
>--- a/drivers/acpi/blacklist.c
>+++ b/drivers/acpi/blacklist.c
>@@ -261,14 +261,6 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
> 	},
> 	{
> 	.callback = dmi_disable_osi_win8,
>-	.ident = "Dell Inspiron 15R SE",
>-	.matches = {
>-		     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>-		     DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7520"),
>-		},
>-	},
>-	{
>-	.callback = dmi_disable_osi_win8,
> 	.ident = "ThinkPad Edge E530",
> 	.matches = {
> 		     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
>index 995e91b..7dc6071 100644
>--- a/drivers/acpi/video.c
>+++ b/drivers/acpi/video.c
>@@ -82,11 +82,12 @@ static bool allow_duplicates;
> module_param(allow_duplicates, bool, 0644);
> 
> /*
>- * For Windows 8 systems: if set ture and the GPU driver has
>- * registered a backlight interface, skip registering ACPI video's.
>+ * For Windows 8 systems: used to decide if video module
>+ * should skip registering backlight interface of its own.
>  */
>-static bool use_native_backlight = false;
>-module_param(use_native_backlight, bool, 0644);
>+static int use_native_backlight_param = -1;
>+module_param_named(use_native_backlight, use_native_backlight_param, int, 0444);
>+static bool use_native_backlight_dmi = false;
> 
> static int register_count;
> static struct mutex video_list_lock;
>@@ -232,9 +233,17 @@ static int acpi_video_get_next_level(struct acpi_video_device *device,
> static int acpi_video_switch_brightness(struct acpi_video_device *device,
> 					 int event);
> 
>+static bool acpi_video_use_native_backlight(void)
>+{
>+	if (use_native_backlight_param != -1)
>+		return use_native_backlight_param;
>+	else
>+		return use_native_backlight_dmi;
>+}
>+
> static bool acpi_video_verify_backlight_support(void)
> {
>-	if (acpi_osi_is_win8() && use_native_backlight &&
>+	if (acpi_osi_is_win8() && acpi_video_use_native_backlight() &&
> 	    backlight_device_registered(BACKLIGHT_RAW))
> 		return false;
> 	return acpi_video_backlight_support();
>@@ -399,6 +408,12 @@ static int __init video_set_bqc_offset(const struct dmi_system_id *d)
> 	return 0;
> }
> 
>+static int __init video_set_use_native_backlight(const struct dmi_system_id *d)
>+{
>+	use_native_backlight_dmi = true;
>+	return 0;
>+}
>+
> static struct dmi_system_id video_dmi_table[] __initdata = {
> 	/*
> 	 * Broken _BQC workaround http://bugzilla.kernel.org/show_bug.cgi?id=13121
>@@ -443,6 +458,46 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
> 		DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 7720"),
> 		},
> 	},
>+	{
>+	 .callback = video_set_use_native_backlight,
>+	 .ident = "ThinkPad T430s",
>+	 .matches = {
>+		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>+		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T430s"),
>+		},
>+	},
>+	{
>+	 .callback = video_set_use_native_backlight,
>+	 .ident = "ThinkPad X230",
>+	 .matches = {
>+		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>+		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X230"),
>+		},
>+	},
>+	{
>+	 .callback = video_set_use_native_backlight,
>+	 .ident = "Lenovo Yoga 13",
>+	 .matches = {
>+		 DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>+		 DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo IdeaPad Yoga 13"),
>+		},
>+	},
>+	{
>+	 .callback = video_set_use_native_backlight,
>+	 .ident = "Dell Inspiron 7520",
>+	 .matches = {
>+		 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>+		 DMI_MATCH(DMI_PRODUCT_VERSION, "Inspiron 7520"),
>+		},
>+	},
>+	{
>+	 .callback = video_set_use_native_backlight,
>+	 .ident = "Acer Aspire 5733Z",
>+	 .matches = {
>+		 DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
>+		 DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5733Z"),
>+		},
>+	},
> 	{}
> };
> 
>diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
>index 84875fd..b639934 100644
>--- a/drivers/acpi/video_detect.c
>+++ b/drivers/acpi/video_detect.c
>@@ -168,14 +168,6 @@ static struct dmi_system_id video_detect_dmi_table[] = {
> 		DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"),
> 		},
> 	},
>-	{
>-	.callback = video_detect_force_vendor,
>-	.ident = "Lenovo Yoga 13",
>-	.matches = {
>-		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>-		DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo IdeaPad Yoga 13"),
>-		},
>-	},
> 	{ },
> };
> 
>-- 
>1.8.4.2
>

Actions: View | Diff

Attachments on bug 903136: 685785 | 685787 | 685788 | 685789 | 760501 | 760502 | 760503 | 775627 | 801151 | 801152 | 801153 | 801154 | 828142 | 842222