Attachment 829631 Details for Bug 1031096 – [PATCH] Croak on failed write into a file

[patch] [PATCH] Croak on failed write into a file

-Croak-on-failed-write-into-a-file.patch (text/plain), 1.28 KB, created by Petr Pisar on 2013-11-27 10:08:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Petr Pisar

Created: 2013-11-27 10:08:00 UTC

Size: 1.28 KB

patch

obsolete

>From 7d8effc5b04adab4768615f8382e8f35dd8e110b Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
>Date: Wed, 27 Nov 2013 10:45:39 +0100
>Subject: [PATCH] Croak on failed write into a file
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The mirror() method saves a document into a file. Any error while
>writing to the file, e.g. no disk space, was ignored. This patch fixes
>it by croaking on such I/O error.
>
>Signed-off-by: Petr PÃsaÅ <ppisar@redhat.com>
>---
> lib/HTTP/Tiny.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/lib/HTTP/Tiny.pm b/lib/HTTP/Tiny.pm
>index e81aa8f..5d494c0 100644
>--- a/lib/HTTP/Tiny.pm
>+++ b/lib/HTTP/Tiny.pm
>@@ -209,7 +209,10 @@ sub mirror {
>     open my $fh, ">", $tempfile
>         or Carp::croak(qq/Error: Could not open temporary file $tempfile for downloading: $!\n/);
>     binmode $fh;
>-    $args->{data_callback} = sub { print {$fh} $_[0] };
>+    $args->{data_callback} = sub {
>+        print {$fh} $_[0]
>+        or Carp::croak(qq/Error: Could not write into temporary file $tempfile: $!\n/);
>+    };
>     my $response = $self->request('GET', $url, $args);
>     close $fh
>         or Carp::croak(qq/Error: Could not close temporary file $tempfile: $!\n/);
>-- 
>1.8.3.1
>

Actions: View | Diff

Attachments on bug 1031096: 829631 | 829632