Attachment 830344 Details for Bug 1033805 – memory leak fix from upstream

[patch] memory leak fix from upstream

0001-Fix-regex-memory-leak-when-saving-file-1033805.patch (text/plain), 2.66 KB, created by Kat on 2013-11-28 19:03:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kat

Created: 2013-11-28 19:03:18 UTC

Size: 2.66 KB

patch

obsolete

>From dfb86961608d88bc75443b079abf622fb398ec01 Mon Sep 17 00:00:00 2001
>From: Ekaterina Gerasimova <kittykat3756@gmail.com>
>Date: Sat, 23 Nov 2013 01:12:37 +0000
>Subject: [PATCH] Fix regex memory leak when saving file (#1033805)
>
>---
> gnucash-regfree-leak.patch | 24 ++++++++++++++++++++++++
> gnucash.spec               |  8 +++++++-
> 2 files changed, 31 insertions(+), 1 deletion(-)
> create mode 100644 gnucash-regfree-leak.patch
>
>diff --git a/gnucash-regfree-leak.patch b/gnucash-regfree-leak.patch
>new file mode 100644
>index 0000000..45bae94
>--- /dev/null
>+++ b/gnucash-regfree-leak.patch
>@@ -0,0 +1,24 @@
>+Index: src/backend/xml/gnc-backend-xml.c
>+===================================================================
>+--- src/backend/xml/gnc-backend-xml.c	(revision 22069)
>++++ src/backend/xml/gnc-backend-xml.c	(revision 22070)
>+@@ -928,6 +928,7 @@
>+             else if (regexec(&pattern, stamp_start, 0, NULL, 0) == 0)
>+                 got_date_stamp = TRUE;
>+ 
>++            regfree(&pattern);
>+             g_free(expression);
>+ 
>+             if (!got_date_stamp) /* Not a gnucash created file after all... */
>+Index: src/html/gnc-html.c
>+===================================================================
>+--- src/html/gnc-html.c	(revision 22069)
>++++ src/html/gnc-html.c	(revision 22070)
>+@@ -179,6 +179,7 @@
>+             machine = g_strndup( path + match[1].rm_so, match[1].rm_eo - match[1].rm_so );
>+         }
>+     }
>++    regfree(&compiled_m);
>+     return machine;
>+ }
>+ 
>diff --git a/gnucash.spec b/gnucash.spec
>index ff008d4..afe516f 100644
>--- a/gnucash.spec
>+++ b/gnucash.spec
>@@ -4,7 +4,7 @@ Name: gnucash
> Summary: Finance management application
> Version: 2.4.13
> URL: http://gnucash.org/
>-Release: 5%{?dist}
>+Release: 6%{?dist}
> License: GPLv2+
> Group: Applications/Productivity
> Source: http://downloads.sourceforge.net/sourceforge/gnucash/gnucash-%{version}.tar.bz2
>@@ -21,6 +21,8 @@ BuildRequires: libtool-ltdl-devel, GConf2-devel
> BuildRequires: ktoblzcheck-devel
> BuildRequires: slib >= 3a1-5
> Patch0: gnucash-quiet.patch
>+# https://bugzilla.gnome.org/show_bug.cgi?id=681907
>+Patch1: gnucash-regfree-leak.patch
> 
> Requires: gnucash-docs >= 2.2.0
> Requires: slib >= 3a1-5
>@@ -45,6 +47,7 @@ balanced books.
> %prep
> %setup -q
> %patch0 -p1
>+%patch1 -p0
> find src/quotes -name "*.in" -exec sed -i "s|use lib '@-PERLINCL-@';||g" {} \;
> 
> %build
>@@ -145,6 +148,9 @@ fi
> %doc doc/README.german doc/README.francais doc/README.OFX doc/README.HBCI
> 
> %changelog
>+* Sat Nov 23 2013 Ekaterina Gerasimova <kittykat3756@gmail.com> - 2.4.13-6
>+- fix regex memory leak when saving a file (#1033805)
>+
> * Mon Sep 23 2013 Bill Nottingham <notting@redhat.com> - 2.4.13-5
> - rebuild against new libofx
> 
>-- 
>1.8.4.2
>

Actions: View | Diff

Attachments on bug 1033805: 828048 | 828117 | 830344