Attachment 830537 Details for Bug 999297 – 0003-Use-keyring-authentication-also-from-menu

[patch] 0003-Use-keyring-authentication-also-from-menu

0003-Use-keyring-authentication-also-from-menu.patch (text/plain), 2.03 KB, created by Andre Heinecke on 2013-11-29 09:05:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andre Heinecke

Created: 2013-11-29 09:05:18 UTC

Size: 2.03 KB

patch

obsolete

>From df83dea7a0c4f14a6a514398f28014ca25bfa63d Mon Sep 17 00:00:00 2001
>From: Andre Heinecke <aheinecke@intevation.de>
>Date: Fri, 29 Nov 2013 09:52:33 +0100
>Subject: [PATCH 3/3] Use keyring authentication also from menu
>
>    When you use the authenticate menu option for a job this
>    now uses the get_authentication method to look up / save
>    credentials also in the gnome keyring if the user requests this.
>---
> jobviewer.py |   26 +++++++++++++++++++++++++-
> 1 files changed, 25 insertions(+), 1 deletions(-)
>
>diff --git a/jobviewer.py b/jobviewer.py
>index cd619a0..5551984 100644
>--- a/jobviewer.py
>+++ b/jobviewer.py
>@@ -1491,8 +1491,32 @@ class JobViewer (GtkGUI):
>         self.update_monitor ()
> 
>     def on_job_authenticate_activate(self, menuitem):
>+        try:
>+            c = cups.Connection (host=self.host,
>+                                 port=self.port,
>+                                 encryption=self.encryption)
>+        except RuntimeError:
>+            return False
>+
>+        jattrs_req = ['job-printer-uri']
>+        pattrs_req = ['auth-info-required', 'device-uri']
>+
>         for jobid in self.jobids:
>-            self.display_auth_info_dialog (jobid)
>+            # Get the requried attributes for this job
>+            jattrs = c.getJobAttributes (jobid,
>+                                         requested_attributes=jattrs_req)
>+            uri = jattrs.get ('job-printer-uri')
>+            pattrs = c.getPrinterAttributes (uri = uri,
>+                                             requested_attributes=pattrs_req)
>+            try:
>+                auth_info_required = pattrs['auth-info-required']
>+            except KeyError:
>+                debugprint ("No auth-info-required attribute; "
>+                            "guessing instead")
>+                auth_info_required = ['username', 'password']
>+
>+            self.get_authentication (jobid, pattrs.get ('device-uri'),
>+                                     auth_info_required, True)
> 
>     def on_refresh_clicked(self, toolbutton):
>         self.monitor.refresh ()
>-- 
>1.7.2.5
>

Actions: View | Diff

Attachments on bug 999297: 814931 | 814932 | 814934 | 830534 | 830535 | 830537