Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 830810 Details for
Bug 1036248
VMware support broken in Fusion 6 and WS 10
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Patch fixing parts 1 and 2 of described bug
libvirt.patch (text/plain), 2.05 KB, created by
Brad Ackerman
on 2013-11-30 02:48:53 UTC
(
hide
)
Description:
Patch fixing parts 1 and 2 of described bug
Filename:
MIME Type:
Creator:
Brad Ackerman
Created:
2013-11-30 02:48:53 UTC
Size:
2.05 KB
patch
obsolete
>diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c >index 027e245..49e593d 100644 >--- a/src/vmware/vmware_conf.c >+++ b/src/vmware/vmware_conf.c >@@ -263,25 +263,27 @@ vmwareExtractVersion(struct vmware_driver *driver) > int ret = -1; > virCommandPtr cmd = NULL; > char * outbuf = NULL; >+ char *errbuf = NULL; > char *bin = NULL; > char *vmwarePath = NULL; >+ char *bufWithContent = NULL; > > if ((vmwarePath = mdir_name(driver->vmrun)) == NULL) > goto cleanup; > > switch (driver->type) { > case VMWARE_DRIVER_PLAYER: >- if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmplayer")) >+ if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmplayer") < 0) > goto cleanup; > break; > > case VMWARE_DRIVER_WORKSTATION: >- if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmware")) >+ if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmware") < 0) > goto cleanup; > break; > > case VMWARE_DRIVER_FUSION: >- if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmware-vmx")) >+ if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmware-vmx") < 0) > goto cleanup; > break; > >@@ -293,18 +295,28 @@ vmwareExtractVersion(struct vmware_driver *driver) > > cmd = virCommandNewArgList(bin, "-v", NULL); > virCommandSetOutputBuffer(cmd, &outbuf); >+ virCommandSetErrorBuffer(cmd, &errbuf); > > if (virCommandRun(cmd, NULL) < 0) > goto cleanup; > >- if (vmwareParseVersionStr(driver->type, outbuf, &version) < 0) >- goto cleanup; >+ /* VMware Fusion 6 outputs version information to stderr, not stdout. >+ If stdout has no output, therefore, use stderr. */ >+ >+ if (strlen(outbuf)) >+ bufWithContent = outbuf; >+ else >+ bufWithContent = errbuf; >+ >+ if (vmwareParseVersionStr(driver->type, bufWithContent, &version) < 0) >+ goto cleanup; > > ret = 0; > > cleanup: > virCommandFree(cmd); > VIR_FREE(outbuf); >+ VIR_FREE(errbuf); > VIR_FREE(bin); > VIR_FREE(vmwarePath); > return ret;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 1036248
: 830810 |
844995