Attachment 831857 Details for Bug 1026283 – Avoid introducing a memory leak

[patch] Avoid introducing a memory leak

leak.patch (text/plain), 1.17 KB, created by Michael Catanzaro on 2013-12-03 02:23:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2013-12-03 02:23:34 UTC

Size: 1.17 KB

patch

obsolete

>From 2f1c6c8d90d6fcae4d6377b8c9310a9b3d89454a Mon Sep 17 00:00:00 2001
>From: Michael Catanzaro <mcatanzaro@gnome.org>
>Date: Mon, 2 Dec 2013 20:15:04 -0600
>Subject: [PATCH] Fix a leak in an error case
>
>---
> src/libtracker-fts/tracker-fts.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/src/libtracker-fts/tracker-fts.c b/src/libtracker-fts/tracker-fts.c
>index 8a9d1f4..89556e9 100644
>--- a/src/libtracker-fts/tracker-fts.c
>+++ b/src/libtracker-fts/tracker-fts.c
>@@ -150,9 +150,7 @@ function_weights (sqlite3_context *context,
> 			g_array_append_val (weight_array, weight);
> 		}
> 
>-		if (rc == SQLITE_DONE) {
>-			rc = sqlite3_finalize (stmt);
>-		}
>+		rc = sqlite3_finalize (stmt);
> 
> 		weights = (guint *) g_array_free (weight_array, FALSE);
> 		g_once_init_leave (&weights_initialized, (rc == SQLITE_OK));
>@@ -193,9 +191,7 @@ function_property_names (sqlite3_context *context,
> 			g_ptr_array_add (names_array, g_strdup (name));
> 		}
> 
>-		if (rc == SQLITE_DONE) {
>-			rc = sqlite3_finalize (stmt);
>-		}
>+		rc = sqlite3_finalize (stmt);
> 
> 		names = (gchar **) g_ptr_array_free (names_array, FALSE);
> 		g_once_init_leave (&names_initialized, (rc == SQLITE_OK));
>-- 
>1.8.3.1
>

Actions: View | Diff

Attachments on bug 1026283: 819049 | 826778 | 828607 | 829845 | 829847 | 831855 | 831857