Attachment 831884 Details for Bug 1037208 – Proposed patch to address -Werror=format-string build failure

[patch] Proposed patch to address -Werror=format-string build failure

bz1037208-fmt-sec.patch (text/plain), 2.60 KB, created by Greg Bailey on 2013-12-03 05:50:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Greg Bailey

Created: 2013-12-03 05:50:36 UTC

Size: 2.60 KB

patch

obsolete

>diff -uNr mup-6.2.orig/mup/main.c mup-6.2/mup/main.c
>--- mup-6.2.orig/mup/main.c	2013-08-30 20:55:48.000000000 -0700
>+++ mup-6.2/mup/main.c	2013-12-02 22:28:06.590851999 -0700
>@@ -661,7 +661,7 @@
> 
> 		/* add enough white space to line things up */
> 		if ((length = strlen(Option_list[n].argument)) < white_length) {
>-			fprintf(stderr, whitespace + length);
>+			fprintf(stderr, "%s", whitespace + length);
> 		}
> 
> 		fprintf(stderr, " %s\n", Option_list[n].explanation);
>diff -uNr mup-6.2.orig/mup/ytab.c mup-6.2/mup/ytab.c
>--- mup-6.2.orig/mup/ytab.c	2013-10-22 17:10:57.000000000 -0700
>+++ mup-6.2/mup/ytab.c	2013-12-02 22:28:06.605851554 -0700
>@@ -7021,7 +7021,7 @@
> 		MALLOCA(char, (yyval.stringval), strlen((yyvsp[(1) - (1)].stringval)) + 3);
> 		(yyval.stringval)[0] = FONT_TR;
> 		(yyval.stringval)[1] = DFLT_SIZE;
>-		sprintf((yyval.stringval) + 2, (yyvsp[(1) - (1)].stringval));
>+		sprintf((yyval.stringval) + 2, "%s", (yyvsp[(1) - (1)].stringval));
> 	}
>     break;
> 
>diff -uNr mup-6.2.orig/mupdisp/mupdisp.c mup-6.2/mupdisp/mupdisp.c
>--- mup-6.2.orig/mupdisp/mupdisp.c	2013-10-24 17:23:12.000000000 -0700
>+++ mup-6.2/mupdisp/mupdisp.c	2013-12-02 22:28:06.606851524 -0700
>@@ -320,7 +320,7 @@
> 	}
> 	/* if there is an error message to print, do so */
> 	if (Exit_errmsg != (char *) 0) {
>-		fprintf(stderr, Exit_errmsg);
>+		fprintf(stderr, "%s", Exit_errmsg);
> 		
> 		/* if there is a ghostscript error file, print it */
> 		if (status != 0) {
>diff -uNr mup-6.2.orig/mupmate/File.C mup-6.2/mupmate/File.C
>--- mup-6.2.orig/mupmate/File.C	2013-01-31 19:41:47.000000000 -0700
>+++ mup-6.2/mupmate/File.C	2013-12-02 22:28:06.606851524 -0700
>@@ -234,7 +234,7 @@
> 		}
> 		else {
> 			filename = new char[strlen(newfile) + 1];
>-			(void) sprintf(filename, newfile);
>+			(void) sprintf(filename, "%s", newfile);
> 		}
> 
> 		set_window_label();
>diff -uNr mup-6.2.orig/mupmate/Main.C mup-6.2/mupmate/Main.C
>--- mup-6.2.orig/mupmate/Main.C	2013-10-24 17:49:48.000000000 -0700
>+++ mup-6.2/mupmate/Main.C	2013-12-02 22:28:06.606851524 -0700
>@@ -860,7 +860,7 @@
> 				"Fix setting of \"Folder for Mup Files\"\n"
> 				"in Config->File Locations.",
> 				mup_dir, curr_dir);
>-			fl_alert(message);
>+			fl_alert("%s", message);
> 		}
> 	}
> 
>diff -uNr mup-6.2.orig/mupmate/Run.C mup-6.2/mupmate/Run.C
>--- mup-6.2.orig/mupmate/Run.C	2013-01-31 19:41:47.000000000 -0700
>+++ mup-6.2/mupmate/Run.C	2013-12-02 22:28:21.998394678 -0700
>@@ -1002,7 +1002,7 @@
> 			// Probably core dump :-(
> 			fl_alert("Mup exited due to signal %d.", WTERMSIG(ret));
> 		} else {
>-			fl_alert(Unknown_Mup_failure);
>+			fl_alert("%s", Unknown_Mup_failure);
> 		}
> #else // WIF... macros not defined
> 		if (ret == -1) {

Actions: View | Diff

Attachments on bug 1037208: 831884