Attachment 831949 Details for Bug 1037250 – Proposed compiler tune

[patch] Proposed compiler tune

0001-Inhibit-compiler-warning-on-sscanf-without-arguments.patch (text/plain), 1.27 KB, created by Petr Pisar on 2013-12-03 09:09:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Petr Pisar

Created: 2013-12-03 09:09:43 UTC

Size: 1.27 KB

patch

obsolete

>From ad7eedc7eb9051443548392884d8c349341fe2f1 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
>Date: Tue, 3 Dec 2013 10:01:55 +0100
>Subject: [PATCH] Inhibit compiler warning on sscanf() without arguments
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This code will not pass if GCC is invoked with
>-Werror=format-security. This is a false positive as the format string
>is sanitized before.
>
><https://bugzilla.redhat.com/show_bug.cgi?id=1037250>
>
>Signed-off-by: Petr PÃsaÅ <ppisar@redhat.com>
>---
> src/ker/goodies.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/src/ker/goodies.c b/src/ker/goodies.c
>index 153a685..039858a 100644
>--- a/src/ker/goodies.c
>+++ b/src/ker/goodies.c
>@@ -845,7 +845,11 @@ scanstr(char *str, char *fmt, Any *r)
>   ar = vsscanf(str, fmt, (va_list) ptrs);
> #else
>   switch(argn)
>-  { case 0:	ar = sscanf(str, fmt); break;
>+  {
>+#pragma GCC diagnostic push
>+#pragma GCC diagnostic ignored "-Wformat-security"
>+    case 0:	ar = sscanf(str, fmt); break;
>+#pragma GCC diagnostic pop
>     case 1:	ar = sscanf(str, fmt, ptrs[0]); break;
>     case 2:	ar = sscanf(str, fmt, ptrs[0], ptrs[1]); break;
>     case 3:	ar = sscanf(str, fmt, ptrs[0], ptrs[1], ptrs[2]);
>-- 
>1.8.3.1
>

Actions: View | Diff

Attachments on bug 1037250: 831949