Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 832441 Details for
Bug 1037966
cvs internal test editor-log-file1 does not pass
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Fix as patch against package sources
0001-Fix-editor-log-file1-test.patch (text/plain), 8.38 KB, created by
Petr Pisar
on 2013-12-04 07:47:22 UTC
(
hide
)
Description:
Fix as patch against package sources
Filename:
MIME Type:
Creator:
Petr Pisar
Created:
2013-12-04 07:47:22 UTC
Size:
8.38 KB
patch
obsolete
>From 87f0063f2ee57b6ce00cd71ad5f840c8c35a55d4 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> >Date: Wed, 4 Dec 2013 08:42:00 +0100 >Subject: [PATCH] Fix editor-log-file1 test >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Petr PÃsaÅ <ppisar@redhat.com> >--- > cvs-1.11.22-cvspass.patch | 66 ----------------------------- > cvs-1.11.23-cvspass.patch | 105 ++++++++++++++++++++++++++++++++++++++++++++++ > cvs.spec | 7 +++- > 3 files changed, 110 insertions(+), 68 deletions(-) > delete mode 100644 cvs-1.11.22-cvspass.patch > create mode 100644 cvs-1.11.23-cvspass.patch > >diff --git a/cvs-1.11.22-cvspass.patch b/cvs-1.11.22-cvspass.patch >deleted file mode 100644 >index f6ff3ea..0000000 >--- a/cvs-1.11.22-cvspass.patch >+++ /dev/null >@@ -1,66 +0,0 @@ >-diff -up cvs-1.11.23/src/login.c.cvspass cvs-1.11.23/src/login.c >---- cvs-1.11.23/src/login.c.cvspass 2008-05-07 11:57:34.000000000 -0400 >-+++ cvs-1.11.23/src/login.c 2008-07-15 15:34:34.000000000 -0400 >-@@ -315,6 +315,15 @@ internal error: can only call password_e >- fp = CVS_FOPEN (passfile, "r"); >- if (fp == NULL) >- { >-+ fp = CVS_FOPEN (passfile, "w"); >-+ if (fp != NULL) >-+ { >-+ fclose (fp); >-+ fp = CVS_FOPEN (passfile, "r"); >-+ } >-+ } >-+ if (fp == NULL) >-+ { >- error (0, errno, "warning: failed to open %s for reading", passfile); >- goto process; >- } >-diff -up cvs-1.11.23/src/logmsg.c.cvspass cvs-1.11.23/src/logmsg.c >---- cvs-1.11.23/src/logmsg.c.cvspass 2008-05-07 11:57:34.000000000 -0400 >-+++ cvs-1.11.23/src/logmsg.c 2008-07-15 15:34:34.000000000 -0400 >-@@ -269,7 +269,7 @@ do_editor (dir, messagep, repository, ch >- } >- >- (void) fprintf (fp, >-- "%s----------------------------------------------------------------------\n", >-+ "\n%s----------------------------------------------------------------------\n", >- CVSEDITPREFIX); >- (void) fprintf (fp, >- "%sEnter Log. Lines beginning with `%.*s' are removed automatically\n%s\n", >-diff -up cvs-1.11.23/src/sanity.sh.cvspass cvs-1.11.23/src/sanity.sh >---- cvs-1.11.23/src/sanity.sh.cvspass 2008-05-06 21:16:00.000000000 -0400 >-+++ cvs-1.11.23/src/sanity.sh 2008-07-15 15:37:43.000000000 -0400 >-@@ -15590,6 +15590,7 @@ description: >- revision 1\.1 >- date: [0-9/]* [0-9:]*; author: ${username}; state: Exp; >- branches: 1\.1\.2; >-+x >- xCVS: ---------------------------------------------------------------------- >- xCVS: Enter Log. Lines beginning with .CVS:. are removed automatically >- xCVS: >-@@ -15601,6 +15602,7 @@ xCVS: ---------------------------------- >- ---------------------------- >- revision 1\.1\.2\.1 >- date: [0-9/]* [0-9:]*; author: ${username}; state: Exp; lines: ${PLUS}1 -0 >-+x >- xCVS: ---------------------------------------------------------------------- >- xCVS: Enter Log. Lines beginning with .CVS:. are removed automatically >- xCVS: >-@@ -15622,6 +15624,7 @@ description: >- revision 1\.1 >- date: [0-9/]* [0-9:]*; author: ${username}; state: Exp; >- branches: 1\.1\.2; >-+x >- xCVS: ---------------------------------------------------------------------- >- xCVS: Enter Log. Lines beginning with .CVS:. are removed automatically >- xCVS: >-@@ -15633,6 +15636,7 @@ xCVS: ---------------------------------- >- ---------------------------- >- revision 1\.1\.2\.1 >- date: [0-9/]* [0-9:]*; author: ${username}; state: Exp; lines: ${PLUS}1 -0 >-+x >- xCVS: ---------------------------------------------------------------------- >- xCVS: Enter Log. Lines beginning with .CVS:. are removed automatically >- xCVS: >diff --git a/cvs-1.11.23-cvspass.patch b/cvs-1.11.23-cvspass.patch >new file mode 100644 >index 0000000..7af4e53 >--- /dev/null >+++ b/cvs-1.11.23-cvspass.patch >@@ -0,0 +1,105 @@ >+From 2f4e47634646fd33fc04d1ce7a28dd15e16b67a1 Mon Sep 17 00:00:00 2001 >+From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> >+Date: Wed, 4 Dec 2013 08:37:24 +0100 >+Subject: [PATCH] Create ~/.cvspass at login if it does not exists >+MIME-Version: 1.0 >+Content-Type: text/plain; charset=UTF-8 >+Content-Transfer-Encoding: 8bit >+ >+<https://bugzilla.redhat.com/show_bug.cgi?id=47457> >+ >+Signed-off-by: Petr PÃsaÅ <ppisar@redhat.com> >+--- >+ src/login.c | 9 +++++++++ >+ src/logmsg.c | 2 +- >+ src/sanity.sh | 6 ++++++ >+ 3 files changed, 16 insertions(+), 1 deletion(-) >+ >+diff --git a/src/login.c b/src/login.c >+index 50b292b..75dc53a 100644 >+--- a/src/login.c >++++ b/src/login.c >+@@ -315,6 +315,15 @@ internal error: can only call password_entry_operation with pserver method"); >+ fp = CVS_FOPEN (passfile, "r"); >+ if (fp == NULL) >+ { >++ fp = CVS_FOPEN (passfile, "w"); >++ if (fp != NULL) >++ { >++ fclose (fp); >++ fp = CVS_FOPEN (passfile, "r"); >++ } >++ } >++ if (fp == NULL) >++ { >+ error (0, errno, "warning: failed to open %s for reading", passfile); >+ goto process; >+ } >+diff --git a/src/logmsg.c b/src/logmsg.c >+index 741231b..0d4d6a2 100644 >+--- a/src/logmsg.c >++++ b/src/logmsg.c >+@@ -269,7 +269,7 @@ do_editor (dir, messagep, repository, changes) >+ } >+ >+ (void) fprintf (fp, >+- "%s----------------------------------------------------------------------\n", >++ "\n%s----------------------------------------------------------------------\n", >+ CVSEDITPREFIX); >+ (void) fprintf (fp, >+ "%sEnter Log. Lines beginning with `%.*s' are removed automatically\n%s\n", >+diff --git a/src/sanity.sh b/src/sanity.sh >+index dbcae19..6ccd698 100755 >+--- a/src/sanity.sh >++++ b/src/sanity.sh >+@@ -15552,6 +15552,7 @@ description: >+ revision 1\.1 >+ date: [0-9/]* [0-9:]*; author: ${username}; state: Exp; >+ branches: 1\.1\.2; >++x >+ xCVS: ---------------------------------------------------------------------- >+ xCVS: Enter Log. Lines beginning with .CVS:. are removed automatically >+ xCVS: >+@@ -15563,6 +15564,7 @@ xCVS: ---------------------------------------------------------------------- >+ ---------------------------- >+ revision 1\.1\.2\.1 >+ date: [0-9/]* [0-9:]*; author: ${username}; state: Exp; lines: ${PLUS}1 -0 >++x >+ xCVS: ---------------------------------------------------------------------- >+ xCVS: Enter Log. Lines beginning with .CVS:. are removed automatically >+ xCVS: >+@@ -15590,6 +15592,7 @@ description: >+ revision 1\.1 >+ date: [0-9/]* [0-9:]*; author: ${username}; state: Exp; >+ branches: 1\.1\.2; >++x >+ xCVS: ---------------------------------------------------------------------- >+ xCVS: Enter Log. Lines beginning with .CVS:. are removed automatically >+ xCVS: >+@@ -15601,6 +15604,7 @@ xCVS: ---------------------------------------------------------------------- >+ ---------------------------- >+ revision 1\.1\.2\.1 >+ date: [0-9/]* [0-9:]*; author: ${username}; state: Exp; lines: ${PLUS}1 -0 >++x >+ xCVS: ---------------------------------------------------------------------- >+ xCVS: Enter Log. Lines beginning with .CVS:. are removed automatically >+ xCVS: >+@@ -15622,6 +15626,7 @@ description: >+ revision 1\.1 >+ date: [0-9/]* [0-9:]*; author: ${username}; state: Exp; >+ branches: 1\.1\.2; >++x >+ xCVS: ---------------------------------------------------------------------- >+ xCVS: Enter Log. Lines beginning with .CVS:. are removed automatically >+ xCVS: >+@@ -15633,6 +15638,7 @@ xCVS: ---------------------------------------------------------------------- >+ ---------------------------- >+ revision 1\.1\.2\.1 >+ date: [0-9/]* [0-9:]*; author: ${username}; state: Exp; lines: ${PLUS}1 -0 >++x >+ xCVS: ---------------------------------------------------------------------- >+ xCVS: Enter Log. Lines beginning with .CVS:. are removed automatically >+ xCVS: >+-- >+1.8.3.1 >+ >diff --git a/cvs.spec b/cvs.spec >index 772ed78..7cf2f2d 100644 >--- a/cvs.spec >+++ b/cvs.spec >@@ -5,7 +5,7 @@ > > Name: cvs > Version: 1.11.23 >-Release: 35%{?dist} >+Release: 36%{?dist} > Summary: Concurrent Versions System > Group: Development/Tools > URL: http://cvs.nongnu.org/ >@@ -42,7 +42,7 @@ BuildRequires: texinfo > BuildRequires: systemd > > # Fix up initial cvs login, bug #47457 >-Patch0: cvs-1.11.22-cvspass.patch >+Patch0: cvs-1.11.23-cvspass.patch > # Build against system zlib > Patch1: cvs-1.11.19-extzlib.patch > # Aadd 't' as a loginfo format specifier (print tag or branch name) >@@ -290,6 +290,9 @@ exit 0 > > > %changelog >+* Wed Dec 04 2013 Petr Pisar <ppisar@redhat.com> - 1.11.23-36 >+- Fix editor-log-file1 test (bug #1037966) >+ > * Tue Dec 03 2013 Petr Pisar <ppisar@redhat.com> - 1.11.23-35 > - Fix compilation with -Wformat-security (bug #1037029) > >-- >1.8.3.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 1037966
:
832441
|
832583