Attachment 832907 Details for Bug 1016382 – patch adding <parameters> to <run> to log Test Parameters in XML

[patch] patch adding <parameters> to <run> to log Test Parameters in XML

0002-1016382-hwcert-client-no-longer-logging-Test-Paramet.patch (text/plain), 2.32 KB, created by Greg Nichols on 2013-12-05 00:48:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Greg Nichols

Created: 2013-12-05 00:48:18 UTC

Size: 2.32 KB

patch

obsolete

>From 39da886ee81c36476045202676f40b760af34db0 Mon Sep 17 00:00:00 2001
>From: Greg Nichols <gnichols@redhat.com>
>Date: Wed, 4 Dec 2013 19:46:59 -0500
>Subject: [PATCH 2/2] 1016382 - hwcert-client no longer logging Test Parameters
>
>---
> hwcert/harness.py     |  1 +
> hwcert/rundocument.py | 14 +++++++++++---
> hwcert/tags.py        |  1 +
> 3 files changed, 13 insertions(+), 3 deletions(-)
>
>diff --git a/hwcert/harness.py b/hwcert/harness.py
>index 281a6e5..939ec66 100644
>--- a/hwcert/harness.py
>+++ b/hwcert/harness.py
>@@ -938,6 +938,7 @@ class HardwareTestHarness(Controller):
>         testParameters = TestParameters(self, testDocument)
>         testParameters.set(Constants.OUTPUTFILE, outputFilePath)
>         test.setParameters(testParameters)
>+        run.setParameters("%s" % testParameters) # log them in the run document
>         if self.options.debug != Constants.off:
>             print "Test Parameters: %s" % testParameters
>         rv = test.run()
>diff --git a/hwcert/rundocument.py b/hwcert/rundocument.py
>index da3555b..2811a2f 100644
>--- a/hwcert/rundocument.py
>+++ b/hwcert/rundocument.py
>@@ -88,7 +88,7 @@ class RunDocument(DocumentWrapper):
>         except IndexError:
>             return None
>         return None
>-        
>+
>     def setSummary(self, summary):
>         summaryElement = self.findOrCreateElement(self.element, Tags.summary)
>         try:
>@@ -96,10 +96,18 @@ class RunDocument(DocumentWrapper):
>         except IndexError:
>             textNode = self.document.createTextNode(summary)
>             summaryElement.appendChild(textNode)
>-    
>+
>+    def setParameters(self, parameters):
>+        parametersElement = self.findOrCreateElement(self.element, Tags.parameters)
>+        try:
>+            parametersElement.childNodes[0].data = parameters
>+        except IndexError:
>+            textNode = self.document.createTextNode(parameters)
>+            parametersElement.appendChild(textNode)
>+
>     def wasRun(self):
>         return self.getSummary() != None
>-    
>+
>     def passed(self):
>         if not self.wasRun():
>             return False
>diff --git a/hwcert/tags.py b/hwcert/tags.py
>index 6712c47..77a3a2a 100644
>--- a/hwcert/tags.py
>+++ b/hwcert/tags.py
>@@ -72,6 +72,7 @@ class Tags:
>    product_url="product-url"
>    catalog_url="catalog-url"
>    category="category"
>+   parameters="parameters"
> 
> 
> class Attributes:
>-- 
>1.8.3.1
>

Actions: View | Diff

Attachments on bug 1016382: 832907 | 834838