Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 833737 Details for
Bug 1039148
CVE-2013-6419 OpenStack Neutron and Nova: Metadata queries from Neutron to Nova are not restricted by tenant
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
cve-2013-6419-nova-stable-havana.patch
cve-2013-6419-nova-stable-havana.patch (text/plain), 7.61 KB, created by
Kurt Seifried
on 2013-12-06 19:28:58 UTC
(
hide
)
Description:
cve-2013-6419-nova-stable-havana.patch
Filename:
MIME Type:
Creator:
Kurt Seifried
Created:
2013-12-06 19:28:58 UTC
Size:
7.61 KB
patch
obsolete
>commit 2a95eee992b66cd65e401e31785c080f811476cf >Author: Aaron Rosen <arosen@nicira.com> >Date: Mon Oct 7 13:33:31 2013 -0700 > > Prevent spoofing instance_id from neturon to nova > > Previously, one could update a port's device_id in neutron to be that > of another tenant's instance_id and then be able to retrieve that instance's > metadata. This patch prevents this from occuring by checking that X-Tenant-ID > received from the metadata request matches the tenant_id in the nova database. > > DocImpact - This patch is dependent on another patch in neutron which adds > X-Tenant-ID to the request. Therefore to minimize downtime one > should upgrade Neutron first (then restart neutron-metadata-agent) > and lastly update nova. > > Fixes bug: 1235450 > >diff --git a/nova/api/metadata/handler.py b/nova/api/metadata/handler.py >index 27f4d4e..7ac9023 100644 >--- a/nova/api/metadata/handler.py >+++ b/nova/api/metadata/handler.py >@@ -140,29 +140,34 @@ class MetadataRequestHandler(wsgi.Application): > 'Please try your request again.') > raise webob.exc.HTTPInternalServerError(explanation=unicode(msg)) > > if meta_data is None: > LOG.error(_('Failed to get metadata for ip: %s'), remote_address) > > return meta_data > > def _handle_instance_id_request(self, req): > instance_id = req.headers.get('X-Instance-ID') >+ tenant_id = req.headers.get('X-Tenant-ID') > signature = req.headers.get('X-Instance-ID-Signature') > remote_address = req.headers.get('X-Forwarded-For') > > # Ensure that only one header was passed > > if instance_id is None: > msg = _('X-Instance-ID header is missing from request.') >+ elif tenant_id is None: >+ msg = _('X-Tenant-ID header is missing from request.') > elif not isinstance(instance_id, basestring): > msg = _('Multiple X-Instance-ID headers found within request.') >+ elif not isinstance(tenant_id, basestring): >+ msg = _('Multiple X-Tenant-ID headers found within request.') > else: > msg = None > > if msg: > raise webob.exc.HTTPBadRequest(explanation=msg) > > expected_signature = hmac.new( > CONF.neutron_metadata_proxy_shared_secret, > instance_id, > hashlib.sha256).hexdigest() >@@ -188,11 +193,19 @@ class MetadataRequestHandler(wsgi.Application): > LOG.exception(_('Failed to get metadata for instance id: %s'), > instance_id) > msg = _('An unknown error has occurred. ' > 'Please try your request again.') > raise webob.exc.HTTPInternalServerError(explanation=unicode(msg)) > > if meta_data is None: > LOG.error(_('Failed to get metadata for instance id: %s'), > instance_id) > >+ if meta_data.instance['project_id'] != tenant_id: >+ LOG.warning(_("Tenant_id %(tenant_id)s does not match tenant_id " >+ "of instance %(instance_id)s."), >+ {'tenant_id': tenant_id, >+ 'instance_id': instance_id}) >+ # causes a 404 to be raised >+ meta_data = None >+ > return meta_data >diff --git a/nova/tests/test_metadata.py b/nova/tests/test_metadata.py >index 50f0d07..e75b51f 100644 >--- a/nova/tests/test_metadata.py >+++ b/nova/tests/test_metadata.py >@@ -594,74 +594,104 @@ class MetadataHandlerTestCase(test.TestCase): > CONF.neutron_metadata_proxy_shared_secret, > expected_instance_id, > hashlib.sha256).hexdigest() > > # try a request with service disabled > response = fake_request( > self.stubs, self.mdinst, > relpath="/2009-04-04/user-data", > address="192.192.192.2", > headers={'X-Instance-ID': 'a-b-c-d', >+ 'X-Tenant-ID': 'test', > 'X-Instance-ID-Signature': signed}) > self.assertEqual(response.status_int, 200) > > # now enable the service > self.flags(service_neutron_metadata_proxy=True) > response = fake_request( > self.stubs, self.mdinst, > relpath="/2009-04-04/user-data", > address="192.192.192.2", > fake_get_metadata_by_instance_id=fake_get_metadata, > headers={'X-Forwarded-For': '192.192.192.2', > 'X-Instance-ID': 'a-b-c-d', >+ 'X-Tenant-ID': 'test', > 'X-Instance-ID-Signature': signed}) > > self.assertEqual(response.status_int, 200) > self.assertEqual(response.body, > base64.b64decode(self.instance['user_data'])) > > # mismatched signature > response = fake_request( > self.stubs, self.mdinst, > relpath="/2009-04-04/user-data", > address="192.192.192.2", > fake_get_metadata_by_instance_id=fake_get_metadata, > headers={'X-Forwarded-For': '192.192.192.2', > 'X-Instance-ID': 'a-b-c-d', >+ 'X-Tenant-ID': 'test', > 'X-Instance-ID-Signature': ''}) > > self.assertEqual(response.status_int, 403) > >+ # missing X-Tenant-ID from request >+ response = fake_request( >+ self.stubs, self.mdinst, >+ relpath="/2009-04-04/user-data", >+ address="192.192.192.2", >+ fake_get_metadata_by_instance_id=fake_get_metadata, >+ headers={'X-Forwarded-For': '192.192.192.2', >+ 'X-Instance-ID': 'a-b-c-d', >+ 'X-Instance-ID-Signature': signed}) >+ >+ self.assertEqual(response.status_int, 400) >+ >+ # mismatched X-Tenant-ID >+ response = fake_request( >+ self.stubs, self.mdinst, >+ relpath="/2009-04-04/user-data", >+ address="192.192.192.2", >+ fake_get_metadata_by_instance_id=fake_get_metadata, >+ headers={'X-Forwarded-For': '192.192.192.2', >+ 'X-Instance-ID': 'a-b-c-d', >+ 'X-Tenant-ID': 'FAKE', >+ 'X-Instance-ID-Signature': signed}) >+ >+ self.assertEqual(response.status_int, 404) >+ > # without X-Forwarded-For > response = fake_request( > self.stubs, self.mdinst, > relpath="/2009-04-04/user-data", > address="192.192.192.2", > fake_get_metadata_by_instance_id=fake_get_metadata, > headers={'X-Instance-ID': 'a-b-c-d', >+ 'X-Tenant-ID': 'test', > 'X-Instance-ID-Signature': signed}) > > self.assertEqual(response.status_int, 500) > > # unexpected Instance-ID > signed = hmac.new( > CONF.neutron_metadata_proxy_shared_secret, > 'z-z-z-z', > hashlib.sha256).hexdigest() > > response = fake_request( > self.stubs, self.mdinst, > relpath="/2009-04-04/user-data", > address="192.192.192.2", > fake_get_metadata_by_instance_id=fake_get_metadata, > headers={'X-Forwarded-For': '192.192.192.2', > 'X-Instance-ID': 'z-z-z-z', >+ 'X-Tenant-ID': 'test', > 'X-Instance-ID-Signature': signed}) > self.assertEqual(response.status_int, 500) > > > class MetadataPasswordTestCase(test.TestCase): > def setUp(self): > super(MetadataPasswordTestCase, self).setUp() > fake_network.stub_out_nw_api_get_instance_nw_info(self.stubs) > self.instance = copy.copy(INSTANCES[0]) > self.instance['system_metadata'] = get_default_sys_meta()
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 1039148
:
833732
|
833733
|
833734
|
833735
|
833736
| 833737