Attachment 835624 Details for Bug 1038887 – patch fix the dead loop issue when trying to install require rpms if enable debug mode

[patch] patch fix the dead loop issue when trying to install require rpms if enable debug mode

0001-1038887-hwcert-backend-Dead-loop-occurs-when-trying-.patch (text/plain), 1.47 KB, created by Dong Zhu on 2013-12-12 06:03:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dong Zhu

Created: 2013-12-12 06:03:40 UTC

Size: 1.47 KB

patch

obsolete

>From f6c9334276dc151f8108a843c0619a3f0b6e5a4d Mon Sep 17 00:00:00 2001
>From: Dong Zhu <dzhu@redhat.com>
>Date: Thu, 12 Dec 2013 13:59:58 +0800
>Subject: [PATCH] 1038887 - hwcert-backend: Dead loop occurs when trying to
> install require rpms if enable debug mode
>
>Signed-off-by: Dong Zhu <dzhu@redhat.com>
>---
> hwcert/harness.py | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/hwcert/harness.py b/hwcert/harness.py
>index ddaee92..eded77a 100644
>--- a/hwcert/harness.py
>+++ b/hwcert/harness.py
>@@ -262,11 +262,12 @@ class HardwareTestHarness(Controller):
>                 print "The following packages are required for testing:"
>                 print ", ".join(missingRPMs)
>                 errorRPMs = list()
>-                if self.options.mode == Constants.auto or self.ui.promptConfirm(prompt):
>+                if self.options.mode == Constants.auto:
>+                    print "Warning: ignoring the missing packages in auto mode."
>+                    return False
>+                elif self.ui.promptConfirm(prompt):
>                     if os.system("yum install -y " + " ".join(missingRPMs)) != 0:
>                         print "Error: could not install required packages."
>-                        if self.options.mode == Constants.auto:
>-                            return False
>                     # otherwise
>                     print "Rechecking required rpms"
>                     prompt = "Would you like to re-try installing the missing packages?"
>-- 
>1.8.3.1
>

Flags:

gnichols: review-

Actions: View | Diff

Attachments on bug 1038887: 835624