Attachment 835708 Details for Bug 1036996 – FTBFS fix

[patch] FTBFS fix

ayttm-format-security.patch (text/plain), 2.39 KB, created by Dhiru Kholia on 2013-12-12 09:40:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dhiru Kholia

Created: 2013-12-12 09:40:12 UTC

Size: 2.39 KB

patch

obsolete

>diff --git a/libproxy/proxy.c b/libproxy/proxy.c
>index 8b2bd6a..c4a7acc 100644
>--- a/libproxy/proxy.c
>+++ b/libproxy/proxy.c
>@@ -311,7 +311,7 @@ int http_connect(int sockfd, const char *host, int port, AyProxyData *proxy)
> 	strncat(cmd, "\r\n", remaining);
> #ifndef DEBUG
> 	snprintf(debug_buff, sizeof(debug_buff), "<%s>\n", cmd);
>-	debug_print(debug_buff);
>+	debug_print("%s", debug_buff);
> #endif
> 	if (send(sockfd, cmd, strlen(cmd), 0) < 0)
> 		return AY_CONNECTION_REFUSED;
>@@ -319,7 +319,7 @@ int http_connect(int sockfd, const char *host, int port, AyProxyData *proxy)
> 		return AY_CONNECTION_REFUSED;
> #ifndef DEBUG
> 	snprintf(debug_buff, sizeof(debug_buff), "<%s>\n", inputline);
>-	debug_print(debug_buff);
>+	debug_print("%s", debug_buff);
> #endif
> 	if (!strstr(inputline, "200")) {
> 		/* Check if proxy authorization needed */
>@@ -346,7 +346,7 @@ int http_connect(int sockfd, const char *host, int port, AyProxyData *proxy)
> 		}
> #ifndef DEBUG
> 		snprintf(debug_buff, sizeof(debug_buff), "<%s>\n", inputline);
>-		debug_print(debug_buff);
>+		debug_print("%s", debug_buff);
> #endif
> 	}
> 	free(inputline);
>diff --git a/src/edit_list_window.c b/src/edit_list_window.c
>index 4ef236c..72c9279 100644
>--- a/src/edit_list_window.c
>+++ b/src/edit_list_window.c
>@@ -372,22 +372,22 @@ static void write_data()
> 	while (data_list) {
> 		my_data = (data *)data_list->data;
> 
>-		fprintf(fp, bentity);
>+		fprintf(fp, "%s", bentity);
> 		fprintf(fp, "\n");
> 		fprintf(fp, "<TITLE>\n");
> 		strncpy(buff2, my_data->title, strlen(my_data->title) + 1);
> 		g_strchomp(buff2);
> 		fprintf(fp, "%s\n", buff2);
> 		fprintf(fp, "</TITLE>\n");
>-		fprintf(fp, bvalue);
>+		fprintf(fp, "%s", bvalue);
> 		fprintf(fp, "\n");
> 		strncpy(buff2, my_data->message->str,
> 			strlen(my_data->message->str) + 1);
> 		g_strchomp(buff2);
> 		fprintf(fp, "%s\n", buff2);
>-		fprintf(fp, evalue);
>+		fprintf(fp, "%s", evalue);
> 		fprintf(fp, "\n");
>-		fprintf(fp, eentity);
>+		fprintf(fp, "%s", eentity);
> 		fprintf(fp, "\n");
> 
> 		data_list = data_list->next;
>diff --git a/src/messages.c b/src/messages.c
>index ea4ec52..c4dbfbb 100644
>--- a/src/messages.c
>+++ b/src/messages.c
>@@ -45,7 +45,7 @@ static void ay_do_message(const char *inTitle, const char *inMessage,
> 	}
> 
> 	dialog = gtk_message_dialog_new_with_markup(NULL, flags, mtype,
>-		GTK_BUTTONS_OK, inMessage);
>+		GTK_BUTTONS_OK, "%s", inMessage);
> 	gtk_window_set_title(GTK_WINDOW(dialog), inTitle);
> 	gtk_widget_show(dialog);
>

Actions: View | Diff

Attachments on bug 1036996: 835707 | 835708