Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 837229 Details for
Bug 1040353
Confusing output with EPEL5 flag
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Fixes the issue properly
fedora-review-epel5.patch (text/plain), 839 bytes, created by
Mattias Ellert
on 2013-12-16 13:45:33 UTC
(
hide
)
Description:
Fixes the issue properly
Filename:
MIME Type:
Creator:
Mattias Ellert
Created:
2013-12-16 13:45:33 UTC
Size:
839 bytes
patch
obsolete
>--- /usr/share/fedora-review/plugins/generic_should.py.orig 2013-12-13 12:40:59.000000000 +0100 >+++ /usr/share/fedora-review/plugins/generic_should.py 2013-12-16 14:25:24.499322022 +0100 >@@ -77,13 +77,13 @@ > self.url = 'http://fedoraproject.org/wiki/' \ > 'Packaging/Guidelines#BuildRoot_tag' > self.text = 'Buildroot is not present' >- if self.flags['EPEL5']: >- self.text = \ >- "Explicit BuildRoot: tag as required by EPEL5 present." > self.automatic = True > self.type = 'SHOULD' > > def run(self): >+ if self.flags['EPEL5']: >+ self.text = \ >+ "Explicit BuildRoot: tag as required by EPEL5 present." > br_tags = self.spec.find_all_re('^BuildRoot') > if len(br_tags) == 0: > if self.flags['EPEL5']:
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=837229">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 1040353
: 837229