Attachment 839236 Details for Bug 1045188 – try all attributes when saving an entry

[patch] try all attributes when saving an entry

LDAP-Try-all-attributes-when-saving-an-entry.patch (text/plain), 1.75 KB, created by Claudio Sampaio on 2013-12-19 20:11:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Claudio Sampaio

Created: 2013-12-19 20:11:31 UTC

Size: 1.75 KB

patch

obsolete

>From 349650b09dff1ab08415e107583bd37cd3537183 Mon Sep 17 00:00:00 2001
>From: Jakub Hrozek <jhrozek@redhat.com>
>Date: Mon, 21 Oct 2013 17:24:16 +0200
>Subject: [PATCH] LDAP: Try all attributes when saving an entry
>
>---
> src/providers/ldap/sdap.c | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
>diff --git a/src/providers/ldap/sdap.c b/src/providers/ldap/sdap.c
>index 07a93ddfbac9d61cb1257855f029f5b972ead533..5d82ea68ffb66a41276d53570c5c7b1eeca2fa9f 100644
>--- a/src/providers/ldap/sdap.c
>+++ b/src/providers/ldap/sdap.c
>@@ -106,7 +106,7 @@ int sdap_parse_entry(TALLOC_CTX *memctx,
>     struct ldb_val v;
>     char *str;
>     int lerrno;
>-    int a, i, ret;
>+    int a, i, ret, ai;
>     const char *name;
>     bool store;
>     bool base64;
>@@ -281,8 +281,18 @@ int sdap_parse_entry(TALLOC_CTX *memctx,
>                         v.length = vals[i]->bv_len;
>                     }
> 
>-                    ret = sysdb_attrs_add_val(attrs, name, &v);
>-                    if (ret) goto done;
>+                    /* The same LDAP attr might be used for more sysdb attrs.
>+                     * Find all that match and copy the value
>+                     */
>+                    for (ai = a; ai < attrs_num; ai++) {
>+                        /* check if this attr is valid with the chosen schema */
>+                        if (!map[ai].name) continue;
>+                        /* check if it is an attr we are interested in */
>+                        if (strcasecmp(base_attr, map[ai].name) == 0) {
>+                            ret = sysdb_attrs_add_val(attrs, map[ai].sys_name, &v);
>+                            if (ret) goto done;
>+                        }
>+                    }
>                 }
>                 ldap_value_free_len(vals);
>             }
>-- 
>1.8.2.1
>

Actions: View | Diff

Attachments on bug 1045188: 839236