Attachment 839504 Details for Bug 1044854 – This patch fix my issue

[patch] This patch fix my issue

perl-DBI-version-fix.diff (text/plain), 1.00 KB, created by Pawel Zaskorski on 2013-12-20 10:16:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pawel Zaskorski

Created: 2013-12-20 10:16:01 UTC

Size: 1.00 KB

patch

obsolete

>--- bugzilla/Bugzilla/Install/Requirements.pm	2013-11-15 00:31:33.000000000 +0100
>+++ bugzilla.new/Bugzilla/Install/Requirements.pm	2013-12-20 08:06:44.145473295 +0100
>@@ -662,18 +662,9 @@
>     # the module isn't loaded.
>     my $vnum = $module->VERSION || -1;
> 
>-    # CGI's versioning scheme went 2.75, 2.751, 2.752, 2.753, 2.76
>-    # That breaks the standard version tests, so we need to manually correct
>-    # the version
>-    if ($module eq 'CGI' && $vnum =~ /(2\.7\d)(\d+)/) {
>-        $vnum = $1 . "." . $2;
>-    }
>-    # CPAN did a similar thing, where it has versions like 1.9304.
>-    if ($module eq 'CPAN' and $vnum =~ /^(\d\.\d{2})\d{2}$/) {
>-        $vnum = $1;
>-    }
>+    # Must do a string comparison as $vnum may be of the form 5.10.1.
>+    my $vok = ($vnum ne '-1' && version->new($vnum) >= version->new($wanted)) ? 1 : 0;
> 
>-    my $vok = (vers_cmp($vnum,$wanted) > -1);
>     my $blacklisted;
>     if ($vok && $params->{blacklist}) {
>         $blacklisted = grep($vnum =~ /$_/, @{$params->{blacklist}});

Actions: View | Diff

Attachments on bug 1044854: 839504