Attachment 842288 Details for Bug 1046917 – 0001-generic_should-fix-self.flags-uninitialized.patch

[patch] 0001-generic_should-fix-self.flags-uninitialized.patch

0001-generic_should-fix-self.flags-uninitialized.patch (text/plain), 2.50 KB, created by Igor Gnatenko on 2013-12-27 11:42:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Igor Gnatenko

Created: 2013-12-27 11:42:32 UTC

Size: 2.50 KB

patch

obsolete

>From dae82fc829dd8afa07974718ae3a6bbe2cea253e Mon Sep 17 00:00:00 2001
>From: Igor Gnatenko <i.gnatenko.brain@gmail.com>
>Date: Fri, 27 Dec 2013 15:30:40 +0400
>Subject: [PATCH] generic_should: fix self.flags uninitialized
>
>Since 178b7b77929119e73f693aa2aca5dab1c68e8252 fedora-review doesn't work.
>
>Traceback (most recent call last):
>  File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 232, in run
>    self._do_run(outfile)
>  File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 222, in _do_run
>    self._do_report(outfile)
>  File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 96, in _do_report
>    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
>  File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 105, in _run_checks
>    self.checks = Checks(spec, srpm)
>  File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 268, in __init__
>    _ChecksLoader.__init__(self)
>  File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 166, in __init__
>    self._load_checks()
>  File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 204, in _load_checks
>    tests = registry.register(plugin)
>  File "/usr/lib/python2.7/site-packages/FedoraReview/registry.py", line 130, in register
>    obj = (c[1])(self.checks)
>  File "/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic_should.py", line 80, in __init__
>    if self.flags['EPEL5']:
>KeyError: 'EPEL5'
>
>Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1046917
>Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
>---
> plugins/generic_should.py | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/plugins/generic_should.py b/plugins/generic_should.py
>index 94c1eb4..12ab313 100644
>--- a/plugins/generic_should.py
>+++ b/plugins/generic_should.py
>@@ -30,6 +30,7 @@ from subprocess import Popen, PIPE
> from FedoraReview import CheckBase, Mock, ReviewDirs
> from FedoraReview import ReviewError             # pylint: disable=W0611
> from FedoraReview import RegistryBase, Settings
>+from FedoraReview import _Flags
> 
> from generic import in_list
> 
>@@ -77,6 +78,7 @@ class CheckBuildroot(GenericShouldCheckBase):
>         self.url = 'http://fedoraproject.org/wiki/' \
>                    'Packaging/Guidelines#BuildRoot_tag'
>         self.text = 'Buildroot is not present'
>+        self.flags = _Flags()
>         if self.flags['EPEL5']:
>             self.text = \
>                 "Explicit BuildRoot: tag as required by EPEL5 present."
>-- 
>1.8.4.2
>

Actions: View | Diff

Attachments on bug 1046917: 842288