Attachment 842883 Details for Bug 1046991 – Updated patch

[patch] Updated patch

hamster-time-tracker-1.03.3-notification-fix.patch (text/plain), 1.81 KB, created by Ankur Sinha (FranciscoD) on 2013-12-29 01:15:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ankur Sinha (FranciscoD)

Created: 2013-12-29 01:15:59 UTC

Size: 1.81 KB

patch

obsolete

>--- src/hamster/lib/desktop.py.orig	2013-12-28 11:18:50.279437922 +1100
>+++ src/hamster/lib/desktop.py	2013-12-28 21:26:44.456425009 +1100
>@@ -32,6 +32,7 @@
> class DesktopIntegrations(object):
>     def __init__(self, storage):
>         self.storage = storage # can't use client as then we get in a dbus loop
>+        self._last_notification = None
> 
>         dbus.mainloop.glib.DBusGMainLoop(set_as_default=True)
>         self.bus = dbus.SessionBus()
>@@ -88,15 +89,21 @@
> 
> 
>     def notify_user(self, summary="", details=""):
>-        if not hasattr(self, "notification_conn"):
>+        if not hasattr(self, "_notification_conn"):
>             self._notification_conn = dbus.Interface(self.bus.get_object('org.freedesktop.Notifications',
>-                                                                         '/org/freedesktop/Notifications'),
>-                                                    dbus_interface='org.freedesktop.Notifications')
>+                                                                         '/org/freedesktop/Notifications',
>+                                                                         follow_name_owner_changes=True),
>+                                                     dbus_interface='org.freedesktop.Notifications')
>+
>         conn = self._notification_conn
> 
>-        conn.Notify("Project Hamster", 5, "hamster-time-tracker",
>-                    summary, details,
>-                    [], {"urgency": 0}, -1)
>+        notification = conn.Notify("Project Hamster", self._last_notification or
>+                                   0, "hamster-time-tracker", summary, details,
>+                                   [], {"urgency": dbus.Byte(0), "transient":
>+                                        True}, -1)
>+
>+        self._last_notification = notification
>+
> 
> 
>     def on_idle_changed(self, event, state):

Actions: View | Diff

Attachments on bug 1046991: 842529 | 842883