Attachment 842991 Details for Bug 1046986 – scroll panel item list automatically on movement (improved)

[patch] scroll panel item list automatically on movement (improved)

xfce4-panel-item-move-scroll.patch (text/plain), 2.16 KB, created by Raphael Groner on 2013-12-29 10:06:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Raphael Groner

Created: 2013-12-29 10:06:41 UTC

Size: 2.16 KB

patch

obsolete

>diff --git a/panel/panel-preferences-dialog.c b/panel/panel-preferences-dialog.c
>index 865d7f3..17266cd 100644
>--- a/panel/panel-preferences-dialog.c
>+++ b/panel/panel-preferences-dialog.c
>@@ -1025,6 +1025,7 @@ panel_preferences_dialog_item_move (GtkWidget              *button,
>       itembar = gtk_bin_get_child (GTK_BIN (dialog->active));
>       position = panel_itembar_get_child_index (PANEL_ITEMBAR (itembar),
>                                                 GTK_WIDGET (provider));
>+      path = gtk_tree_model_get_path (GTK_TREE_MODEL (dialog->store), &iter_a);
> 
>       if (G_LIKELY (position != -1))
>         {
>@@ -1051,19 +1052,19 @@ panel_preferences_dialog_item_move (GtkWidget              *button,
>               iter_b = iter_a;
>               if (gtk_tree_model_iter_next (GTK_TREE_MODEL (dialog->store), &iter_b))
>                 gtk_list_store_swap (dialog->store, &iter_a, &iter_b);
>+
>+              /* keep new position */
>+              gtk_tree_path_next (path);
>             }
>           else
>             {
>               /* get the previous item in the list */
>-              path = gtk_tree_model_get_path (GTK_TREE_MODEL (dialog->store), &iter_a);
>               if (gtk_tree_path_prev (path))
>                 {
>                   /* swap the items in the list */
>                   gtk_tree_model_get_iter (GTK_TREE_MODEL (dialog->store), &iter_b, path);
>                   gtk_list_store_swap (dialog->store, &iter_a, &iter_b);
>                 }
>-
>-              gtk_tree_path_free (path);
>             }
> 
>           /* fake update the selection */
>@@ -1071,6 +1072,12 @@ panel_preferences_dialog_item_move (GtkWidget              *button,
>           panel_return_if_fail (GTK_IS_WIDGET (treeview));
>           selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (treeview));
>           panel_preferences_dialog_item_selection_changed (selection, dialog);
>+
>+          /* make the new selected position visible if moved out of area */
>+          gtk_tree_view_scroll_to_cell (GTK_TREE_VIEW (treeview), path, NULL, FALSE, 0, 0);
>+          gtk_tree_view_set_cursor (GTK_TREE_VIEW (treeview), path, NULL, FALSE);
>+
>+          gtk_tree_path_free (path);
>         }
>     }
> }

Actions: View | Diff

Attachments on bug 1046986: 842506 | 842991