Attachment 846518 Details for Bug 1047603 – review.txt

review.txt

review.txt (text/plain), 7.86 KB, created by Remi Collet on 2014-01-07 09:02:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2014-01-07 09:02:36 UTC

Size: 7.86 KB

patch

obsolete

>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>[x]: Requires correct, justified where necessary.
>  optional, so packager choice
>  php-hash
>  php-mhash (emulated by hash in recent php, not available in EL-6)
>  php-pear(phpseclib.sourceforge.net/Math_BigInteger) >= 0.3.0
>
>Math_BigInteger seems mandatory for sha512 when hash/mhash not available
>but hash is always available (currently in php-common).
>I think it's still usefull to explicit requires one.
>
>[-]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>  License text included in the single source file.
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "MIT/X11 (BSD like)". Detailed output of licensecheck in
>     /home/extras/SPECS/review/1047603-php-phpseclib-crypt-
>     hash/licensecheck.txt
>[x]: Package does not own files or directories owned by other packages.
>     Note: Dirs in package are owned also by: /usr/share/pear/Crypt(php-
>     phpseclib-crypt-des, php-pear-Crypt-Blowfish, php-phpseclib-crypt-
>     rijndael, php-pear-Crypt-CHAP)
>[x]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[x]: Sources contain only permissible code or content.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[-]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Requires correct, justified where necessary.
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Package is not known to require an ExcludeArch tag.
>[x]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: Package requires other packages for directories it uses.
>[x]: Package must own all directories that it creates.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Each %files section contains %defattr if rpm < 4.4
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package do not use a name that already exist
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 0 bytes in 0 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>===== SHOULD items =====
>
>Generic:
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[-]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[?]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[-]: Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Sources can be downloaded from URI in Source: tag
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[x]: Dist tag is present (not strictly required in GL).
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Fully versioned dependency in subpackages if applicable.
>[x]: SourceX tarball generation or download is documented.
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>[x]: Spec file according to URL is the same as in SRPM.
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>     Note:  Time: 1.31 seconds, Memory: 13.50Mb Required PHP 5.0.0 (min) phpci
>     static analyze results in /home/extras/SPECS/review/1047603-php-
>     phpseclib-crypt-hash/phpci.log
>
>
>Rpmlint
>-------
>Checking: php-phpseclib-crypt-hash-0.3.5-2.fc19.noarch.rpm
>          php-phpseclib-crypt-hash-0.3.5-2.fc19.src.rpm
>php-phpseclib-crypt-hash.noarch: W: spelling-error %description -l en_US mhash -> mash, hash, m hash
>php-phpseclib-crypt-hash.noarch: W: spelling-error %description -l en_US suhosin -> housing
>php-phpseclib-crypt-hash.noarch: W: no-documentation
>php-phpseclib-crypt-hash.src: W: spelling-error %description -l en_US mhash -> mash, hash, m hash
>php-phpseclib-crypt-hash.src: W: spelling-error %description -l en_US suhosin -> housing
>2 packages and 0 specfiles checked; 0 errors, 5 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-phpseclib-crypt-hash
>php-phpseclib-crypt-hash.noarch: W: spelling-error %description -l en_US mhash -> mash, hash, m hash
>php-phpseclib-crypt-hash.noarch: W: spelling-error %description -l en_US suhosin -> housing
>php-phpseclib-crypt-hash.noarch: W: no-documentation
>1 packages and 0 specfiles checked; 0 errors, 3 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-phpseclib-crypt-hash (rpmlib, GLIBC filtered):
>    /bin/sh
>    /usr/bin/pear
>    php-channel(phpseclib.sourceforge.net)
>    php-pear(PEAR)
>
>
>
>Provides
>--------
>php-phpseclib-crypt-hash:
>    php-pear(phpseclib.sourceforge.net/Crypt_Hash)
>    php-phpseclib-crypt-hash
>
>
>
>Source checksums
>----------------
>http://phpseclib.sourceforge.net/get/Crypt_Hash-0.3.5.tgz :
>  CHECKSUM(SHA256) this package     : cf13e248da88a7a04ab9d040edd060825c87b127e4ed63c2313e66d95f63423f
>  CHECKSUM(SHA256) upstream package : cf13e248da88a7a04ab9d040edd060825c87b127e4ed63c2313e66d95f63423f
>
>
>Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
>Command line :/usr/bin/fedora-review -b 1047603
>Buildroot used: fedora-19-x86_64
>Active plugins: Generic, PHP, Shell-api
>Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, Ruby
>Disabled flags: EPEL5, EXARCH, DISTTAG

Actions: View

Attachments on bug 1047603: 846517 | 846518